Replace libdparse with DMD in IfConstraintsIndentCheck #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladiwostok
force-pushed
the
if-constraints
branch
from
4afedef
to
7b5ec89
Compare
Vladiwostok
force-pushed
the
if-constraints
branch
2 times, most recently
from
1041c8c
to
7d5a20c
Compare
Vladiwostok
commented
Oct 25, 2024
|
|
||
| @("issue #829") |
There was a problem hiding this comment.
Removed as this no longer applies with current code
Vladiwostok
force-pushed
the
if-constraints
branch
from
7d5a20c
to
f7b5c90
Compare
RazvanN7
reviewed
Nov 8, 2024
| } | ||
|
|
||
| override void visit(const InterfaceDeclaration decl) | ||
| private void lexFile() |
There was a problem hiding this comment.
I have seen this method before. Maybe it should be made public and let all visitors use it.
RazvanN7
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.