Separate analyze with dmd and autofix flows from libdparse analyze flow #142
Conversation
src/dscanner/analysis/unused.d
Outdated
There was a problem hiding this comment.
This is no longer used at all in the project
| import dscanner.analysis.unused_result : UnusedResultChecker; | ||
| import dscanner.analysis.unused_variable : UnusedVariableCheck; | ||
| import dscanner.analysis.useless_assert : UselessAssertCheck; | ||
| import dscanner.analysis.useless_initializer : UselessInitializerChecker; |
There was a problem hiding this comment.
why not simply import dscanner.analysis?
There was a problem hiding this comment.
It's much more cleaner this way. The idea is to organize in the future the src files in analysis dir in other dirs, it will be easier then
There was a problem hiding this comment.
I don't see how importing dscanner.analysis is less cleaner even if you do shuffle files inside the analysis directory.
There was a problem hiding this comment.
It's easier to see which files and which declarations are actually used when refactoring. A full dscanner.analysis import would also include other modules unrelated to the checks.
Without specific imports, you either have to read the code to verify used imports on rely on compiler errors.
There was a problem hiding this comment.
This is the main file that uses all the checks. Most of the files in the analysis folder will be needed and all of them implement a single visitor (so you could even make them general imports, not selective ones), so I don't see the argument for spelling them out (and with selective imports too). This to me seems java-level prolixity, however, this really isn't a debate worth our time - do as you wish.
Break down different flows in separate files so that it's easier to work on individual flows