Fix segfault caused by UnusedLabelCheck #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vladiwostok
force-pushed
the
fix-unused-label-segf
branch
2 times, most recently
from
5dc990d
to
97b081e
Compare
Vladiwostok
force-pushed
the
fix-unused-label-segf
branch
from
97b081e
to
92f0976
Compare
Vladiwostok
force-pushed
the
fix-unused-label-segf
branch
from
9978f7b
to
bfcc870
Compare
Vladiwostok
force-pushed
the
fix-unused-label-segf
branch
from
bfcc870
to
0160413
Compare
edi33416
requested changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asm support for long instruction arch has been added in phobos.
The visit function for AsmStatement in UnusedLabelCheck uses the instruction's token name (ident.toString()) in order to check for jump instruction. For some reason, the token's identifier gets initialized, however the identifier's name does not (its char* is null).
EDIT: The segfault was caused by using the token's identifier, which is part of a union. In some cases, the union member initialized is not the identifier.