Skip to content

Commit

Permalink
webpack shouldn't be a peerDependency
Browse files Browse the repository at this point in the history
  • Loading branch information
ndbroadbent committed Oct 9, 2019
1 parent 2a0ad57 commit eb30b64
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 4 deletions.
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -165,9 +165,10 @@ Before submitting a pull request, please check the following:
- All code is formatted with [Prettier](https://prettier.io/)
- `yarn format`
- If you use VS Code, you should enable the `formatOnSave` option.
- Using the correct webpack version
- Using the correct webpack version as a dependency
- `yarn update_deps`
- NOTE: The `webpack` peerDependency is only needed to silence some annoying warnings from NPM.
- NOTE: The `webpack` dependency is needed to silence some annoying warnings from NPM.
This must always match the version from `react-scripts`.

## Releasing a new version

Expand Down
3 changes: 1 addition & 2 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,8 +43,7 @@
},
"peerDependencies": {
"@craco/craco": "^5.5.0",
"react-scripts": "^3.2.0",
"webpack": "4.41.0"
"react-scripts": "^3.2.0"
},
"husky": {
"hooks": {
Expand Down

0 comments on commit eb30b64

Please sign in to comment.