Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow timepicker container to be an element #6623

Open
wants to merge 1 commit into
base: v1-dev
Choose a base branch
from
Open

Allow timepicker container to be an element #6623

wants to merge 1 commit into from

Conversation

Cerothen
Copy link

@Cerothen Cerothen commented Jan 11, 2021

Proposed changes

The datepicker requires an element to be specified for the container, the time picker requires a selector string. This change allows an element to be specified while retaining the original method as a fallback

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to change).

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@Huluti
Copy link

Huluti commented Feb 9, 2021

Hi! You shoud probably propose this change in this active fork: https://github.com/materializecss/materialize

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants