Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Deploy storybook automatically, without relying on build artifacts in repo #782

Merged
merged 1 commit into from
Jun 14, 2023

Conversation

henningmu
Copy link
Contributor

Closes #252
Part of #675

Short description

Previously, one would be required to run npm run build-all and commit the updated files from docs/ folder to this repository. This made reviews harder, was cumbersome and error-prone. With this PR, it's a thing of the past. We're now building and deploying the storybook from a GitHub Action on each commit on main. Proper CD if you will 💫

@henningmu henningmu added the Show label Jun 14, 2023
@henningmu henningmu requested a review from gnapse June 14, 2023 12:35
@henningmu henningmu self-assigned this Jun 14, 2023
@henningmu henningmu merged commit 39b4b37 into main Jun 14, 2023
@henningmu henningmu deleted the henningmu/storybook-deployment branch June 14, 2023 12:45
@gnapse
Copy link
Contributor

gnapse commented Jun 14, 2023

Applause

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Do we need built assets in git
2 participants