Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Improve DX when developing against another repo #831

Merged
merged 7 commits into from
Jul 24, 2024

Conversation

pawelgrimm
Copy link
Contributor

@pawelgrimm pawelgrimm commented Jul 19, 2024

Short description

We are implementing a yalc-based workflow for working on Reactist and seeing those changed reflected in a locally running app that has a dependency on Reactist.

This partially addresses #675:

To make it easier to work with Reactist locally, in development mode, alongside our product apps

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

This is a DX-only change that does not require a new version release.

@pawelgrimm pawelgrimm changed the base branch from main to next July 19, 2024 16:01
@pawelgrimm pawelgrimm self-assigned this Jul 19, 2024
@pawelgrimm pawelgrimm marked this pull request as ready for review July 22, 2024 20:09
@gnapse gnapse self-requested a review July 23, 2024 02:22
Copy link
Contributor

@craigcarlyle craigcarlyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Contributor

@gnapse gnapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Can't wait to see it in action.

Unfortunately, I saw this today too late to try it. Will try this Wednesday. I did leave some comments here of a couple of things that are unclear to me.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@pawelgrimm pawelgrimm merged commit c71e151 into next Jul 24, 2024
2 checks passed
@pawelgrimm pawelgrimm deleted the pawel/feat/improve-reactist-dx-with-todoist branch July 24, 2024 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants