Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Better icon alignment for the Notice component #848

Merged
merged 1 commit into from
Nov 11, 2024
Merged

fix: Better icon alignment for the Notice component #848

merged 1 commit into from
Nov 11, 2024

Conversation

rfgamaral
Copy link
Member

@rfgamaral rfgamaral commented Nov 11, 2024 •
edited
Loading

Short description

This fixes the vertical alignment for icons in the Notice component (https://github.com/Doist/Issues/issues/15416).

PR Checklist

  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Patch

@rfgamaral rfgamaral added the Show label Nov 11, 2024
@rfgamaral rfgamaral requested a review from a team November 11, 2024 11:09
@rfgamaral rfgamaral self-assigned this Nov 11, 2024
@rfgamaral rfgamaral requested review from gnapse and removed request for a team November 11, 2024 11:09
@rfgamaral rfgamaral merged commit 5fee496 into main Nov 11, 2024
5 checks passed
@rfgamaral rfgamaral deleted the ricardo/align-notice-icon branch November 11, 2024 11:17
@rfgamaral rfgamaral mentioned this pull request Nov 11, 2024
Merged
2 tasks
gnapse
gnapse reviewed Nov 11, 2024
View reviewed changes
Copy link
Contributor

@gnapse gnapse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnapse gnapse gnapse left review comments

Assignees

@rfgamaral rfgamaral

Labels
Show
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rfgamaral @gnapse