Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set <Prose> horizontal rule color to Divider/Primary #852

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

pawelgrimm
Copy link
Contributor

@pawelgrimm pawelgrimm commented Dec 11, 2024

Short description

We are changing the color of the horizontal rules in <Prose> to Divider/Primary, instead of Divider/Secondary. Also, we are exposing this as a new custom CSS Property (--reactist-prose-horizontal-rule-color) so that consumers can override the new behavior, if desired.

PR Checklist

  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Bug fix

@pawelgrimm pawelgrimm requested review from a team and frankieyan and removed request for a team December 11, 2024 19:18
@pawelgrimm pawelgrimm self-assigned this Dec 11, 2024
@pawelgrimm pawelgrimm merged commit 75441cd into main Dec 12, 2024
4 of 5 checks passed
@pawelgrimm pawelgrimm deleted the pawel/fix/prose-primary-border branch December 12, 2024 18:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants