Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Prefer flipping submenu to left side over to the bottom #853

Merged
merged 2 commits into from
Dec 14, 2024

Conversation

frankieyan
Copy link
Member

@frankieyan frankieyan commented Dec 12, 2024

Short description

In #844, submenus were set up to render on the bottom if there isn't enough space to the right. Visually this doesn't look quite correct when the menu is placed closer to the right side of the screen and that there's space on the left, so having the left side as the first fallback should be preferred.

Before After
image image

PR Checklist

  • Added tests for bugs / new features
  • Updated docs (storybooks, readme)
  • Executed npm run validate and made sure no errors / warnings were shown
  • Described changes in CHANGELOG.md
  • Bumped version in package.json and package-lock.json (npm --no-git-tag-version version <major|minor|patch>) ref
  • Reviewed and approved Chromatic visual regression tests in CI

Versioning

Patch

@frankieyan frankieyan force-pushed the frankie/submenu-flip-left branch from 5318e94 to fbda888 Compare December 14, 2024 05:02
@frankieyan frankieyan merged commit 10ef8be into main Dec 14, 2024
5 checks passed
@frankieyan frankieyan deleted the frankie/submenu-flip-left branch December 14, 2024 05:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant