Skip to content

Commit

Permalink
fix: only try batch requests with non-empty entries
Browse files Browse the repository at this point in the history
  • Loading branch information
brandon-doist committed Jul 31, 2024
1 parent 256afc5 commit 05d4478
Showing 1 changed file with 16 additions and 14 deletions.
30 changes: 16 additions & 14 deletions sqs_workers/queue.py
Original file line number Diff line number Diff line change
Expand Up @@ -148,24 +148,26 @@ def _handle_processed(self, messages_with_success: Iterable[Tuple[Any, bool]]):
}
)

ack_response = queue.delete_messages(Entries=entries_to_ack)
if len(entries_to_ack) > 0:
ack_response = queue.delete_messages(Entries=entries_to_ack)

if ack_response.get("Failed"):
logger.warning(
"Failed to delete processed messages from queue",
extra={"queue": self.name, "failures": ack_response["Failed"]},
)

viz_response = queue.change_message_visibility_batch(
Entries=entries_to_change_viz,
)
if ack_response.get("Failed"):
logger.warning(
"Failed to delete processed messages from queue",
extra={"queue": self.name, "failures": ack_response["Failed"]},
)

if viz_response.get("Failed"):
logger.warning(
"Failed to change visibility of messages which failed to process",
extra={"queue": self.name, "failures": viz_response["Failed"]},
if len(entries_to_change_viz) > 0:
viz_response = queue.change_message_visibility_batch(
Entries=entries_to_change_viz,
)

if viz_response.get("Failed"):
logger.warning(
"Failed to change visibility of messages which failed to process",
extra={"queue": self.name, "failures": viz_response["Failed"]},
)

return result

def process_message(self, message: Any) -> bool:
Expand Down

0 comments on commit 05d4478

Please sign in to comment.