Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: more improvements to in-memory SQS #102

Merged
merged 1 commit into from
Jul 31, 2024
Merged

Conversation

brandon-doist
Copy link
Contributor

Now it finally operates quite similarly to the real SQS -- change_visibility doesn't additionally remove the message from in_flight like it used to (which was a bit of a hack), and instead receive_messages will do that before getting the list of messages to return to the client, respecting the timeout.

@brandon-doist brandon-doist marked this pull request as ready for review July 31, 2024 18:02
@brandon-doist brandon-doist merged commit a64b136 into main Jul 31, 2024
12 checks passed
@brandon-doist brandon-doist deleted the brandon/improve-memory branch July 31, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant