Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support project.can_assign_tasks #132

Merged
merged 2 commits into from
Apr 18, 2024
Merged

feat: Support project.can_assign_tasks #132

merged 2 commits into from
Apr 18, 2024

Conversation

amix
Copy link
Member

@amix amix commented Apr 11, 2024

Context

Supports the change coming from https://github.com/Doist/Todoist/pull/15002 where we are adding a project.can_assign_tasks flag with the following logic:

  • can_assign_tasks would be true for shared personal projects (and becomes false when the project becomes unshared)
  • can_assign_tasks would be true for all workspace projects

This flag will help resolve https://github.com/Doist/Issues/issues/11930

Refs

@amix amix requested a review from goncalossilva April 11, 2024 08:58
Copy link
Member

@goncalossilva goncalossilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending our discussion in https://github.com/Doist/Todoist/pull/15002.

todoist_api_python/models.py Show resolved Hide resolved
@goncalossilva goncalossilva changed the title feat: Support project.allow_assignment feat: Support project.can_assign_tasks Apr 16, 2024
@amix amix merged commit a86432d into main Apr 18, 2024
1 check passed
@amix amix deleted the amix/ft.allow-assignment branch April 18, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants