Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use correct Node and Parent types from unist #376

Merged
merged 1 commit into from
Aug 4, 2023

Conversation

rfgamaral
Copy link
Member

Overview

With the automatic PR from Renovate to bump @types/hast to v3, I've realized that the Node and Parent from that package were being used incorrectly. The correct types to be used are from the unist package because the visit and remove utilities come from unist-util- dependencies.

PR Checklist

@rfgamaral rfgamaral added the ⛴ Ship PR Used for PRs that don't need a review and can be merged when CI is green. label Aug 4, 2023
@rfgamaral rfgamaral self-assigned this Aug 4, 2023
@netlify
Copy link

netlify bot commented Aug 4, 2023

Deploy Preview for doist-typist ready!

Name Link
🔨 Latest commit bbc67a0
🔍 Latest deploy log https://app.netlify.com/sites/doist-typist/deploys/64cd219e2dcbec0008c52d3e
😎 Deploy Preview https://deploy-preview-376--doist-typist.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rfgamaral rfgamaral enabled auto-merge (squash) August 4, 2023 16:05
@rfgamaral rfgamaral merged commit 525c347 into main Aug 4, 2023
9 checks passed
@rfgamaral rfgamaral deleted the ricardo/fix-hast-types branch August 4, 2023 16:07
@doistbot
Copy link
Member

doistbot commented Aug 4, 2023

🎉 This PR is included in version 1.4.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@doistbot doistbot added the released Pull requests that have been released to production label Aug 4, 2023
jerrywcy pushed a commit to jerrywcy/memos-typist-editor that referenced this pull request Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Pull requests that have been released to production ⛴ Ship PR Used for PRs that don't need a review and can be merged when CI is green.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants