chore(storybook): Prevent keyDown propagation with hidden suggestion dropdown
#919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfgamaral
added
the
⛴ Ship PR
✅ Deploy Preview for doist-typist ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
rfgamaral
force-pushed
the
ricardo/review-suggestion-examples
branch
from
2df5657
to
983b772
Compare
rfgamaral
changed the title
keyDown propagation with hidden suggestion dropdownkeyDown propagation with hidden suggestion dropdown
|
🎉 This PR is included in version 7.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Both the
MentionandHashtagsuggestion dropdowns have an issue where anykeyDownevent is propagated to the dropdown renderer component after the dropdown has been hidden. This PR fixes that by detecting whether the dropdown is hidden or not, and disallowing thekeyDownevent propagation in case it's hidden.Note
This does not affect the production Typist build, it only fixes the Storybook examples.
PR Checklist