Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new stable release v13.0.0 #72

Merged
merged 9 commits into from
Aug 15, 2024
Merged

new stable release v13.0.0 #72

merged 9 commits into from
Aug 15, 2024

Conversation

gnapse
Copy link
Contributor

@gnapse gnapse commented Aug 13, 2024

Now that Reactist is back to having all the new changes in a stable non-beta release (v25.0.0), this pull request brings that Reactist version to the ui-extensions, and brings this repo's recent changes in next back to main.

This pull request will be released as a new version v13.0.0 of the ui extensions react package.

@gnapse gnapse requested a review from scottlovegrove August 13, 2024 18:10
@gnapse gnapse self-assigned this Aug 13, 2024
@gnapse
Copy link
Contributor Author

gnapse commented Aug 14, 2024

Now, after having made the peer dependency change, there's a failed check in CI. Though, it does not look related to the peer dependency change. It's an npm audit warning about the package braces. 😕


Update: it does have to do with the change to peer dependency. What happens is that we have a CI step that runs npm run audit --omit=dev. When Reactist is a dev dependency, it is not being included in this check. But when it switches to be only a peer dependency, it is part of this check.

However, I'm still confused. This braces dependency does not seem to be introduced by Reactist (see screenshot below). So I'm not sure how excluding Reactist from the dev dependency suddenly surfaces this warning.

Screenshot

CleanShot 2024-08-14 at 21 12 05@2x

Anyway, I'm going to revert the change to make Reactist a peer dependency only. We can revisit this soon, but I need to be unblocked now.

@gnapse gnapse force-pushed the ernesto/new-stable-release branch from 6851005 to edadaa8 Compare August 15, 2024 01:09
@gnapse
Copy link
Contributor Author

gnapse commented Aug 15, 2024

@scottlovegrove what's the procedure to release? I assume that after merging I need to do something else, but I'm not sure. I also did not find anything in the README about it.

@scottlovegrove
Copy link
Contributor

@scottlovegrove what's the procedure to release? I assume that after merging I need to do something else, but I'm not sure. I also did not find anything in the README about it.

It just needs a new tag creating once the PR is merged to main. Tag should be react-v<number>

I should add that to the readme 👍🏻

@gnapse
Copy link
Contributor Author

gnapse commented Aug 15, 2024

I assume the by "a new tag" you mean "a new release" in https://github.com/Doist/ui-extensions/releases, which creates a new tag, and also has a description, etc. I'll create it.

@gnapse gnapse merged commit 56c8cd1 into main Aug 15, 2024
6 checks passed
@gnapse gnapse deleted the ernesto/new-stable-release branch August 15, 2024 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants