-
-
Notifications
You must be signed in to change notification settings - Fork 952
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(i18n): update zh-Hans translations #1511
base: canary
Are you sure you want to change the base?
feat(i18n): update zh-Hans translations #1511
Conversation
Fixing: #1429 (review) |
2cf7868
to
b4e7bc4
Compare
CI lint-and-typecheck task failed since this PR: #1508 |
b4e7bc4
to
261f144
Compare
Not sure if the practice of putting all translations in the same file will significantly slow down our page loads, since the hydration data will now contain two translation files for the locale. What do you think? @Siumauricio |
You are right @PaiJi , it can lead to large json file transfers in SSR, |
So what's our plan? using this solution for now, until we refactor the dashboard with tanstack (I just read in another issue that you're considering refactoring to tanstack)? |
Yes, for the moment you can leave it as it was using separate json so that the json download is not so big, regarding the migration to tanstack, if it is something I've been seeing for a couple of months, it is what most resembles nextjs and work integrations like trpc, better auth and many things very easily, besides we would be using vite which is three times faster than what nextjs currently offers, so if this is in my plans, I'm just waiting for tanstack remove vinxi, and is even much lighter to create a plan for migration |
Just to confirm, I'm going to continue to keep the translation files for the individual pages in a different json (i.e. roll back your changes) until we rewrite to tanstack or something else. |
This PR focus on add zh-Hans translation for common UI(sidebar) mostly.