Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(i18n): update zh-Hans translations #1511

Draft
wants to merge 14 commits into
base: canary
Choose a base branch
from

Conversation

PaiJi
Copy link
Contributor

@PaiJi PaiJi commented Mar 16, 2025

This PR focus on add zh-Hans translation for common UI(sidebar) mostly.

@PaiJi
Copy link
Contributor Author

PaiJi commented Mar 16, 2025

Fixing: #1429 (review)
Fixed in 261f144

@PaiJi PaiJi force-pushed the feat/update-zh-Hans-translation-reopen branch from 2cf7868 to b4e7bc4 Compare March 16, 2025 18:11
@PaiJi
Copy link
Contributor Author

PaiJi commented Mar 16, 2025

CI lint-and-typecheck task failed since this PR: #1508
@Siumauricio

@PaiJi PaiJi force-pushed the feat/update-zh-Hans-translation-reopen branch from b4e7bc4 to 261f144 Compare March 17, 2025 07:21
@PaiJi
Copy link
Contributor Author

PaiJi commented Mar 17, 2025

Not sure if the practice of putting all translations in the same file will significantly slow down our page loads, since the hydration data will now contain two translation files for the locale. What do you think? @Siumauricio

@Siumauricio
Copy link
Contributor

You are right @PaiJi , it can lead to large json file transfers in SSR,

@PaiJi
Copy link
Contributor Author

PaiJi commented Mar 17, 2025

You are right @PaiJi , it can lead to large json file transfers in SSR,

So what's our plan? using this solution for now, until we refactor the dashboard with tanstack (I just read in another issue that you're considering refactoring to tanstack)?

@Siumauricio
Copy link
Contributor

You are right @PaiJi , it can lead to large json file transfers in SSR,

So what's our plan? using this solution for now, until we refactor the dashboard with tanstack (I just read in another issue that you're considering refactoring to tanstack)?

Yes, for the moment you can leave it as it was using separate json so that the json download is not so big,

regarding the migration to tanstack, if it is something I've been seeing for a couple of months, it is what most resembles nextjs and work integrations like trpc, better auth and many things very easily, besides we would be using vite which is three times faster than what nextjs currently offers, so if this is in my plans, I'm just waiting for tanstack remove vinxi, and is even much lighter to create a plan for migration

@PaiJi
Copy link
Contributor Author

PaiJi commented Mar 23, 2025

You are right @PaiJi , it can lead to large json file transfers in SSR,

So what's our plan? using this solution for now, until we refactor the dashboard with tanstack (I just read in another issue that you're considering refactoring to tanstack)?

Yes, for the moment you can leave it as it was using separate json so that the json download is not so big,

regarding the migration to tanstack, if it is something I've been seeing for a couple of months, it is what most resembles nextjs and work integrations like trpc, better auth and many things very easily, besides we would be using vite which is three times faster than what nextjs currently offers, so if this is in my plans, I'm just waiting for tanstack remove vinxi, and is even much lighter to create a plan for migration

Just to confirm, I'm going to continue to keep the translation files for the individual pages in a different json (i.e. roll back your changes) until we rewrite to tanstack or something else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants