made the project compatible with netstandard2.0 #483
Conversation
| @@ -1,7 +1,7 @@ | |||
| <Project Sdk="Microsoft.NET.Sdk"> | |||
|
|
|||
| <PropertyGroup> | |||
| <TargetFrameworks>net5.0;net6.0;net7.0;net48;netstandard2.1</TargetFrameworks> | |||
| <TargetFrameworks>net5.0;net6.0;net7.0;net48;netstandard2.0</TargetFrameworks> | |||
There was a problem hiding this comment.
I cannot see the reason of this downgrade.
Could you justify why should be implemented for 2.0 instead of 2.1?
Can you add 2.0 without removing the 2.1?
| @@ -30,7 +30,7 @@ public DwgHandleWriter(ACadVersion version, MemoryStream stream, Dictionary<ulon | |||
| this._handleMap.Add(item.Key, item.Value); | |||
| } | |||
| #else | |||
| this._handleMap = new Dictionary<ulong, long>(map.OrderBy(o => o.Key)); | |||
There was a problem hiding this comment.
I think this fixed some issues for the dwg output, it cannot be removed.
There was a problem hiding this comment.
Can I get any example dwg file that faces issues with this being not changed?
I am doubting that because, you are creating a new Dictionary. The order of the collection that you are providing shouldn't have any effect because dictionaries are unordered collections.
If you can give me a dwg file with the issues mentioned, then I can dig deep into it.
There was a problem hiding this comment.
I don't have any particular example, I just remember that with some specific versions of dwg is better to sort the handles before writing them.
|
Fix compatibility for netstandard20 without compromising the project or code. |
Description
just 4 file was affected and the changes are very small.