-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create informaten.com.gameserver_generic.json #580
Conversation
Linter OK:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Template has errors.
Please check with online editor, just by replacing not (yet) supported variables in ttl/port/protocol with static values.
BTW: I created an issue to make changes in the online editor (or in fact the library behind) but I must be honest here that likely I won't be able to tackle it before mid March.
Domain-Connect/DomainConnectApplyZone#14
"records": [ | ||
{ | ||
"type": "A", | ||
"host": "%host%", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
%host% is a special variable - please refer to the spec.
Please note that host is prepended to all hosts when the template is applied, so you'd rather want to put '@' here.
"priority": "%priority%", | ||
"weight": "%weight%", | ||
"port": "%port%", | ||
"target": "%host%.%fqdn%.", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the intention is to have the same template applied several times with the same host and service values, but different randomnumber I would suggest to set the template to multiinstance (and read carefully the relevant part of the spec).
Also, due to some unclarity in the spec (see Domain-Connect/spec#117) identified recently, I suggest in this case to define A and SRV as two groupId and skip SRV group if one is already existing - otherwise the second instance of the template may render a conflict with the fist one if an identical record would be rendered.
A potentially easier alternative would be to define SRV as essential=OnApply. This would cope with the problem in other way without groups and prior lookup in DNS, however with a small drawback that someone may drop SRV record and leave A still in the zone (for providers which care about template integrity - see again spec).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the template again, now without a random number. It is not intended that a user adds the template multiple times for the same service and fqdn.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kerolasa can you take a look at this template? |
Would it be better to add two different templates for tcp and udp instead of using a variable for protocol to avoid incompatibility with DNS Providers? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The SRV _proto field warning is just a warning. I might change linter to allow variable in that context as well.
https://github.com/Domain-Connect/dc-template-linter/wiki/DCTL1015
Other than that the template look acceptable to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok
Description
The new template should simplify the connection of custom domains to our gameservers (Minecraft, FimeM etc.) .
Type of change
Please mark options that are relevant.
How Has This Been Tested?
Please mark the following checks done
RESOLVED:
I was not able to test the template in the online editor because it doesn't support variables for numeric fields like ttl or the SRV parameters.
The linter shows a warning for the SRV protocol variable saying that the value is invalid. But according to the example in this repository (README) and the spec, this sould be no problem-
<providerId>.<serviceId>.json
Example variable values