many fixes to Issue#561 #594
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Domiii
reviewed
Nov 5, 2021
| @@ -229,6 +229,14 @@ class SyncGraphBase extends GraphBase { | |||
| this._selectContextNode(contextNode); | |||
| } | |||
|
|
|||
| getChildrenCounts() { | |||
There was a problem hiding this comment.
this is not plural -> count, not counts
Domiii
reviewed
Nov 5, 2021
| return this.children.getComponents('ContextNode').length; | ||
| } | ||
|
|
||
| getSubGraphChildrenCounts() { |
There was a problem hiding this comment.
this is not plural -> count, not counts
Domiii
reviewed
Nov 5, 2021
| @@ -149,6 +149,14 @@ class ContextNode extends HostComponentEndpoint { | |||
| this.controllers.getComponent('GraphNode').setMode(GraphNodeMode.ExpandChildren); | |||
| } | |||
|
|
|||
| getChildrenCounts() { | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
runWithProgressBarwont returnTracesByCalleeTraceIndexsuccessfeatureContextNodewith more than 10000 childrenStatsByContextQueryto exclude virtual roots when traversenpmInstallafter switch to a bug tag#561