Fixed issues on home page and committees

DominikNoga · May 30, 2024 · 872cfd0 · 872cfd0
1 parent 91bf0f7
commit 872cfd0
Show file tree

Hide file tree

Showing 7 changed files with 12 additions and 9 deletions.
diff --git a/...ts/pagesHelperComponents/committees-page/chairs-list-item/chairs-list-item.component.html b/...ts/pagesHelperComponents/committees-page/chairs-list-item/chairs-list-item.component.html
@@ -16,7 +16,9 @@
         </div>
         <div class="chair-socials">
             <span *ngIf="chair.links.email" class="chair-social-link" title="Send email">
-                <fa-icon [icon]="EMAIL_ICON"></fa-icon>
+                <a href="mailto:{{chair.links.email}}">
+                    <fa-icon [icon]="EMAIL_ICON"></fa-icon>
+                </a>
             </span>
             <span *ngIf="chair.links.linkedin" class="chair-social-link" title="See linkedin profile">
                 <a href="{{ chair.links.linkedin }}" target="_blank">

diff --git a/...ents/pagesHelperComponents/committees-page/chairs-list-item/chairs-list-item.component.ts b/...ents/pagesHelperComponents/committees-page/chairs-list-item/chairs-list-item.component.ts
@@ -20,5 +20,4 @@ export class ChairsListItemComponent implements OnInit {
 
   ngOnInit(): void {
   }
-
 }
diff --git a/...src/app/components/pagesHelperComponents/home-page/twitts-list/twitts-list.component.html b/...src/app/components/pagesHelperComponents/home-page/twitts-list/twitts-list.component.html
@@ -1,6 +1,6 @@
 <div class="twitts-list-wrapper">
     <header class="twitts-list-header" (click)="goToTwitter()">
-        <a target="_blank" [href]="LINK_TO_ISD_TWITTER">Tweets from @isdconf</a>
+        <a target="_blank" [href]="LINK_TO_ISD_TWITTER">Tweets from &#64;isdconf</a>
     </header>
     <div class="twitts-list-content">
         <div class="twitter-icon">
@@ -16,6 +16,8 @@
                 </span>
             </div>
         </div>
-        <button class="see-twitts-btn">View on Twitter</button>
+        <a class="see-twitts-btn" target="_blank" [href]="LINK_TO_ISD_TWITTER">
+            View on Twitter
+        </a>
     </div>
 </div>
diff --git a/...src/app/components/pagesHelperComponents/home-page/twitts-list/twitts-list.component.scss b/...src/app/components/pagesHelperComponents/home-page/twitts-list/twitts-list.component.scss
@@ -57,6 +57,7 @@ $border: 1px solid rgba(0, 0, 0, 0.3);
             font-weight: bold;
             border-radius: 2rem;
             padding: .7rem 1rem;
+            text-align: center;
             @include addOpacityTransition();
         }
     }

diff --git a/ISD-conference-web-app-frontend/src/app/services/csv-data/csv-data.service.ts b/ISD-conference-web-app-frontend/src/app/services/csv-data/csv-data.service.ts
@@ -105,10 +105,9 @@ export class CsvDataService {
           university: csvItem.affiliation
         },
         function: csvItem.role,
-        photo: `assets/mock_chair_img/${csvItem['first name']}_${csvItem['last name']}.jpg`,
+        photo: `${this.ASSETS_IMG_PREFIX}/${csvItem['first name']}_${csvItem['last name']}.jpg`,
         links: {
           email: csvItem.email || '',
-          linkedin: csvItem['Web page'] || '',
         }
       }));
   }

diff --git a/ISD-conference-web-app-frontend/src/assets/csv/committes.csv b/ISD-conference-web-app-frontend/src/assets/csv/committes.csv
@@ -173,8 +173,8 @@ id,person id,first name,last name,email,country,affiliation,Web page,role,track_
 172,175,Małgorzata,Porada Rochoń,,Poland,University of Szczecin,,PC member,6,T6
 173,72,Alexander,Poth,,Germany,Volkswagen AG,,PC member,3,T3
 174,73,Henderik A.,Proper,,Austria,"TU Wien, Vienna, Austria",http://www.erikproper.eu,PC member,7,T7
-175,6,Adam,Przybylek,,Poland,Gdansk University of Technology,https://github.com/przybylek,superchair,,
-176,6,Adam,Przybylek,,Poland,Gdansk University of Technology,https://github.com/przybylek,track chair,3,T3
+175,6,Adam,Przybyłek,,Poland,Gdansk University of Technology,https://github.com/przybylek,superchair,,
+176,6,Adam,Przybyłek,,Poland,Gdansk University of Technology,https://github.com/przybylek,track chair,3,T3
 177,176,Michal,Przybylek,,Poland,Warsaw University,,PC member,3,T3
 178,177,Sandro,Radovanović,,Serbia,"University of Belgrade, Faculty of Organizational Sciences",,PC member,4,T4
 179,74,Raman,Ramsin,,Iran,Sharif University of Technology,http://sharif.edu/~ramsin/,PC member,3,T3

diff --git a/ISD-conference-web-app-frontend/src/assets/csv/organizing_committe.csv b/ISD-conference-web-app-frontend/src/assets/csv/organizing_committe.csv
@@ -1,5 +1,5 @@
 name,surname,workplace_country,workplace_university,function,links_email,links_linkedin,links_orcid
-Bartosz,Marcinkowski,Poland,University of Gdańsk,General Chair,,https://www.linkedin.com/in/bartosz-marcinkowski-905a222/,https://orcid.org/0000-0002-7230-2978,
+Bartosz,Marcinkowski,Poland,University of Gdańsk,General Chair,[email protected],https://www.linkedin.com/in/bartosz-marcinkowski-905a222/,https://orcid.org/0000-0002-7230-2978,
 Adam,Przybyłek,Poland,Gdańsk University of Technology,Program Chair,,https://www.linkedin.com/in/adampap/,https://orcid.org/0000-0002-8231-709X,
 Yen Ying,Ng,Poland,Nicolaus Copernicus University,Publicity Chair,,https://www.linkedin.com/in/yen-ying-ng/,https://orcid.org/0000-0001-5388-2025,
 Aleksander,Jarzębowicz,Poland,Gdańsk University of Technology,Proceedings Chair,,https://www.linkedin.com/in/aleksander-jarz%C4%99bowicz-124233269/,https://orcid.org/0000-0003-3181-4210,
Original file line number	Diff line number	Diff line change
Expand Up		@@ -20,5 +20,4 @@ export class ChairsListItemComponent implements OnInit {

		ngOnInit(): void {
		}

		}