Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge master to register #26

Merged
merged 23 commits into from
May 21, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
e21fce8
with burger
Apr 24, 2024
f31c795
no burger
Apr 24, 2024
2aeb2ee
added tracks from csv
Apr 25, 2024
f626458
kinda works
DawJas May 7, 2024
2f4585f
rewritten the code a bit
DawJas May 8, 2024
192b835
add linkedin icon
annazhurba May 8, 2024
20d9a7c
fix style for "travel information page
annazhurba May 8, 2024
ed93cea
Merge pull request #21 from DominikNoga/Feature/register-page
krzysiek581234 May 8, 2024
d03122b
brak przecinka
krzysiek581234 May 8, 2024
7e0ebe3
added committees page
May 9, 2024
67d73db
Merge branch 'master' of https://github.com/DominikNoga/ISD-conferenc…
May 9, 2024
f708e9d
Merge pull request #19 from DominikNoga/feature/addStickyHeader
DominikNoga May 9, 2024
a1423b1
Merge pull request #20 from DominikNoga/Feature/addLinkedinWidget
DominikNoga May 9, 2024
83cb4f7
Merge branch 'master' of https://github.com/DominikNoga/ISD-conferenc…
May 9, 2024
115698f
Merge pull request #22 from DominikNoga/Feature/addCommitteesPage
DominikNoga May 9, 2024
6b59111
fixed deploy
May 9, 2024
18dfbac
fixed scrolling to top and displayed tracks on hp
May 9, 2024
e48219a
Merge pull request #23 from DominikNoga/Bug/fixScrollToTopAndTracksOnHp
DominikNoga May 9, 2024
0ce3918
Change text on location page
annazhurba May 9, 2024
e856e33
Merge branch 'Feature/styleTravelInformation' into Feature/addLocatio…
annazhurba May 9, 2024
a7a00c9
fixed the header and the linkedin logo
DawJas May 9, 2024
3c1dd10
Merge pull request #24 from DominikNoga/Feature/addLocationPageToMaster
DawJas May 9, 2024
954b01e
Merge pull request #25 from DominikNoga/Feature/fix_header_adn_linked…
DominikNoga May 9, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions ISD-conference-web-app-frontend/angular.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,13 +37,13 @@
"budgets": [
{
"type": "initial",
"maximumWarning": "500kb",
"maximumError": "1mb"
"maximumWarning": "1mb",
"maximumError": "5mb"
},
{
"type": "anyComponentStyle",
"maximumWarning": "4kb",
"maximumError": "10kb"
"maximumError": "20kb"
}
],
"fileReplacements": [
Expand Down
2 changes: 1 addition & 1 deletion ISD-conference-web-app-frontend/src/app/app.component.html
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
<div class="content-wrapper">
<span id="top-of-page"></span>
<isd-header></isd-header>
<div class="router-content">
<router-outlet>

</router-outlet>
</div>
<isd-footer></isd-footer>
Expand Down
1 change: 1 addition & 0 deletions ISD-conference-web-app-frontend/src/app/app.component.scss
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
}
.router-content {
background-color: $white-darker;
padding-top: 50px;
flex: 1;
}
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,17 @@
<div class="burger" (click)="toggleNav()">
<span class="bar" [ngClass]="getAnimationClass('top-bar')"></span>
<span class="bar" [ngClass]="getAnimationClass('middle-bar')"></span>
<span class="bar" [ngClass]="getAnimationClass('bottom-bar')"></span>
<div class="burger" (click)="onBurgerClickHandler()">
<span
[ngStyle]="{'background-color': barsColor}"
class="bar"
[ngClass]="getAnimationClass('top-bar')">
</span>
<span
[ngStyle]="{'background-color': barsColor}"
class="bar"
[ngClass]="getAnimationClass('middle-bar')">
</span>
<span
[ngStyle]="{'background-color': barsColor}"
class="bar"
[ngClass]="getAnimationClass('bottom-bar')">
</span>
</div>
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { Component, OnInit } from '@angular/core';
import { Component, EventEmitter, Input, OnInit, Output } from '@angular/core';
import { get } from 'lodash-es';
import { NavService } from 'src/app/services/nav/nav.service';

@Component({
Expand All @@ -9,25 +10,21 @@ import { NavService } from 'src/app/services/nav/nav.service';
export class BurgerComponent implements OnInit {
readonly CLOSED = 'closed';
readonly OPENED = 'opened';
animationClass!: string;
@Input() barsColor: string = 'white';
@Input() animationClass!: string;
@Output() onBurgerClick = new EventEmitter<void>();

constructor(private navService: NavService) { }

ngOnInit(): void {
this.navService.animationClass$.subscribe(animationClass => {
this.animationClass = animationClass;
});
}

toggleNav() {
this.navService.toggleBurgerNav();
this.setAnimationClass();
}
getAnimationClass = (className: string) => `${className}-${this.animationClass}`;

setAnimationClass = () => {
if(typeof this.animationClass === 'undefined'){
this.animationClass = this.CLOSED;
return;
}
this.animationClass = this.animationClass === this.OPENED ? this.CLOSED : this.OPENED;
onBurgerClickHandler = () => {
this.onBurgerClick.emit();
}

getAnimationClass = (className: string) => `${className}-${this.animationClass}`;
}
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
<div class="bottom-footer-wrapper">
<section class="bottom-footer">
<span class="copyright">&copy; ISD 2025 City, Country</span>
<a href="#top" class="backToTop"><span>Back to top</span><fa-icon [icon]="upIcon"></fa-icon></a>
<span (click)="scrollToElement($event, 'top-of-page')" class="backToTop"><span>Back to top</span><fa-icon [icon]="upIcon"></fa-icon></span>
</section>
</div>
</footer>
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,7 @@
@include simpleFlexLayout($direction: row, $align-items: center, $gap: 0.5*$default-gap);
&:hover {
color: white;
cursor: pointer;
}
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,13 @@ export class FooterComponent implements OnInit {
ngOnInit(): void {
}

scrollToElement(event: Event, elementId: string): void {
event.preventDefault();
const element = document.getElementById(elementId);
console.log(element)
if (element) {
element.scrollIntoView({ behavior: 'smooth' });
}
}

}
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
<header class="isd-header" id="top">
<div class = "wrapper" [ngClass]="{'visible': isMenuVisible}" (window:scroll)="onScroll($event)">
<header class="isd-header" id="top-header">
<div class="logo">
<div class="rectangle"></div>
<div class="logo-container">
Expand All @@ -7,10 +8,11 @@
</a>
</div>
<div class="burger-wrapper" *ngIf="displayBurgerNav()">
<isd-burger></isd-burger>
<isd-burger animationClass="animationClass" (onBurgerClick)="toggleBurgerNav()"></isd-burger>
</div>
<div class="triangle">
</div>
</div>
<isd-nav></isd-nav>
</header>
</div>
Original file line number Diff line number Diff line change
@@ -1,11 +1,22 @@
@import '../../../styles/isd-variables.scss';
@import '../../../styles/isd-mixins.scss';

.isd-header {

.wrapper{
width:100%; //stretch the header so the bar looks okay when scrolling up
position:fixed;
z-index: 1; //display header above anything else
transition: 0.3s ease;
visibility: hidden; //by default, the header is invisible, the .visible class handles making it visible
top: -100px;
background-color: $white-darker;

.isd-header {

width:92%;
$logo-size: 70px;
$padding-value: 4em;
@include simpleFlexLayout($direction: row, $gap: 0);
position: relative;

.logo {
@include simpleFlexLayout($direction: row, $gap: 0);
Expand All @@ -25,6 +36,8 @@
}
}
}



.burger-wrapper {
background-color: $primary-bg-color;
Expand All @@ -35,7 +48,7 @@
}

.triangle {
$triangle-size: calc($logo-size + 2rem);
$triangle-size: calc($logo-size + 3rem);
width: 0;
height: 0;
border-left: $triangle-size solid $primary-bg-color;
Expand All @@ -44,3 +57,10 @@
}

}
}

.visible{
visibility:visible;
top: 0px
}

Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, OnInit } from '@angular/core';
import { Component, OnInit, HostListener } from '@angular/core';
import { NavService } from 'src/app/services/nav/nav.service';

@Component({
Expand All @@ -7,12 +7,44 @@ import { NavService } from 'src/app/services/nav/nav.service';
styleUrls: ['./header.component.scss']
})
export class HeaderComponent implements OnInit {
burgerAnimationClass!: string;

constructor(private navService: NavService) { }

ngOnInit(): void {
this.navService.animationClass$.subscribe(animationClass => {
this.burgerAnimationClass = animationClass;
});
}

displayBurgerNav(): boolean {
return this.navService.displayBurgerNav();
}

isMenuVisible = true;
lastScrollTop = 0;

@HostListener('window:scroll', ['$event'])
onScroll(event: Event) {
let currentScroll = window.scrollY ;
let delta = 5;

//debonce the scroll
if(Math.abs(this.lastScrollTop - currentScroll) >= delta){
//if scrolling up, or if the user is on the top of the page show the header
if (currentScroll >= this.lastScrollTop && window.scrollY > 70) {
// Scrolling down
this.isMenuVisible = false;
} else {
// Scrolling up
this.isMenuVisible = true;
}

this.lastScrollTop = currentScroll;
}
}

toggleBurgerNav = (): void => {
this.navService.toggleBurgerNav();
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,10 @@

.page-header {
width: 100%;
font-size: $font-size-huge;
font-size: $font-size-extra-huge;
font-weight: bold;
font-family: $roboto-header;
text-align: center;
padding-top: $content-gap-from-nav;
margin-bottom: 4*$default-gap;
}
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="chair-list-item-wrapper">
<div class="chair-function">
<div *ngIf="displayTitle" class="chair-function">
{{ chair.function }}
</div>
<div class="chairs-list-item">
Expand All @@ -19,7 +19,7 @@
<fa-icon [icon]="EMAIL_ICON"></fa-icon>
</span>
<span class="chair-social-link" title="See linkedin profile">
<a href="{{ chair.links.linkedin }}">
<a href="{{ chair.links.linkedin }}" target="_blank">
<fa-icon [icon]="LINKEDIN_ICON"></fa-icon>
</a>
</span>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ import { faEnvelope } from '@fortawesome/free-solid-svg-icons';
})
export class ChairsListItemComponent implements OnInit {
@Input() chair!: Chair;
@Input() displayTitle = false;
readonly ORCID_ICON = faOrcid;
readonly LINKEDIN_ICON = faLinkedin;
readonly EMAIL_ICON = faEnvelope;
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
<div class="chairs-list" id="{{ listId }}">
<isd-chairs-list-item *ngFor="let chair of chairs" [chair]="chair"></isd-chairs-list-item>
<isd-chairs-list-item *ngFor="let chair of chairs" [chair]="chair" [displayTitle]="true"></isd-chairs-list-item>
</div>
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ export class ChairsListComponent implements OnInit {
constructor(private csvDataService: CsvDataService) { }

ngOnInit(): void {
this.csvDataService.getCommittiesData().subscribe(chairs => {
this.csvDataService.getOrganizingCommitteeData().subscribe(chairs => {
this.chairs = chairs;
})
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import { CommonModule } from "@angular/common";
import { RouterModule } from "@angular/router";
import { FontAwesomeModule } from "@fortawesome/angular-fontawesome";
import { UiComponentsModule } from "../../isd-ui/components.module";

import { SideNavComponent } from './side-nav/side-nav.component';
import { ChairsListComponent } from './chairs-list/chairs-list.component';
import { ChairsListItemComponent } from './chairs-list-item/chairs-list-item.component';
Expand All @@ -11,6 +12,7 @@ import { FullTracksListItemComponent } from './full-tracks-list-item/full-tracks
import { SideNavItemComponent } from './side-nav-item/side-nav-item.component';
import { HttpClientModule } from "@angular/common/http";


@NgModule({
declarations: [
SideNavComponent,
Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1,21 @@
<p>full-tracks-list-item works!</p>
<div class="track-container" id="{{track.name}}">
<isd-section-header>{{ track.name }}: {{ track.title }}</isd-section-header>
<section>
<isd-section-header class="header-smaller">Track Chairs</isd-section-header>
<div class="track-chairs">
<isd-chairs-list-item *ngFor="let chair of track.chairs" [chair]="chair"></isd-chairs-list-item>
</div>
</section>

<section>
<isd-section-header class="header-smaller">Program Committee</isd-section-header>
<div class="program-committee">
<ul class="pc-list">
<li *ngFor="let pcMember of track.committee">
{{ pcMember.name }}, {{ pcMember.workplace ? pcMember.workplace.university : '' }}
</li>
</ul>
</div>
</section>

</div>
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
@import "../../../../styles/isd-mixins.scss";
@import "../../../../styles/isd-variables.scss";

.track-container {
.header-smaller {
font-size: 0.8em;
}

> section {
margin-top: $default-gap;
.track-chairs {
@include simpleFlexLayout(row);
}

.program-committee {
padding-left: 2rem;
.pc-list {
list-style-type: disc;
padding: 0;
margin: 0;
}
}
}

}
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import { Component, OnInit } from '@angular/core';
import { Component, Input, OnInit } from '@angular/core';
import { Track } from 'src/app/interfaces/Track';

@Component({
selector: 'isd-full-tracks-list-item',
templateUrl: './full-tracks-list-item.component.html',
styleUrls: ['./full-tracks-list-item.component.scss']
})
export class FullTracksListItemComponent implements OnInit {
@Input() track!: Track;

constructor() { }

Expand Down
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
<p>full-tracks-list works!</p>
<div class="tracks-list-wrapper">
<div class="tracks-list">
<isd-full-tracks-list-item *ngFor="let track of tracks" [track]="track"></isd-full-tracks-list-item>
</div>
Loading