[feat] 체크리스트 관련 기능 #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OJOJIN
reviewed
Jan 3, 2024
|
|
||
| public void updateCheckList(Long userId, CheckListRequestDto checkListRequestDto) { | ||
| User user = findByIdOrThrow(userId); | ||
| CheckList checkList = user.getCheckList(); |
There was a problem hiding this comment.
유저의 체크리스트가 없을 때 예외처리를 해줘도 좋지 않을까 생각해봅니다!
There was a problem hiding this comment.
처음에는 삭제 기능이 없는 것 같아 해당 예외처리를 넣지 않았었는데 있는 게 더 나을 거 같네요~! 추가했습니당 🙇🏻♀️
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🪢
Summary 🌿
Before i request PR review 🧤
🐜
풀이 안 당겨지는 걸 보니 충돌이 뭔가 있나본데.. pr 올리고 고쳐볼게용
엥? 충돌이 없다