Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 게시글 상세 조회 api 구현 #21

Merged
merged 7 commits into from
Jan 4, 2024
Merged

Conversation

RyuKwanKon
Copy link
Contributor

Related Issue 🪢

Summary 🌿

  • 게시글 상세 조회 api 구현했습니다.
  • 단일 post 조회를 위해 restful api 원칙에 따라 id를 이용한 pathvariable을 사용하였습니다.
  • 쿼리 조회시 optional을 이용해 null을 허용하고 service 단에서 예외 처리를 해주었습니다.

Before i request PR review 🧤

  • 코드리뷰로 확인 부탁하는 사항

@RyuKwanKon RyuKwanKon merged commit 94b7195 into develop Jan 4, 2024
1 check passed
Copy link
Contributor

@OJOJIN OJOJIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@@ -97,6 +123,10 @@ public Page<PostSearchDto> searchTextPost(String text, Pageable pageable) {
return PageableExecutionUtils.getPage(content, pageable, countQuery::fetchCount);
}

private BooleanExpression containPostId(Long postId) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메소드명이 contain이 아니라 eqPostId 돼야할 것 같아요!

@RyuKwanKon RyuKwanKon self-assigned this Jan 6, 2024
@RyuKwanKon RyuKwanKon added the FEAT 새로운 기능을 추가 label Jan 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
FEAT 새로운 기능을 추가
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feat] 게시글 상세 조회 api 구현
2 participants