Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] 성별 검색 필터 기능 추가 #28

Merged
merged 8 commits into from
Jan 6, 2024
Merged

[fix] 성별 검색 필터 기능 추가 #28

merged 8 commits into from
Jan 6, 2024

Conversation

RyuKwanKon
Copy link
Contributor

Related Issue 🪢

Summary 🌿

  • 검색 api에서 성별 조건을 추가했습니다.
  • 복잡한 검색 조건을 condition 객체를 만들어 관리하였습니다.
  • 필요하지 않는 조건의 경우 null을 허용해 처리하였고, 최대한 서비스 로직에서 추상화하여 사용자가 null을 다루는 경우를 없앴습니다.

Before i request PR review 🧤

  • 오타 확인해주세여

@RyuKwanKon RyuKwanKon added the FEAT 새로운 기능을 추가 label Jan 6, 2024
@RyuKwanKon RyuKwanKon self-assigned this Jan 6, 2024
OJOJIN
OJOJIN approved these changes Jan 6, 2024
View reviewed changes
Copy link
Contributor

@OJOJIN OJOJIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!
전에도 생각했는데 프론트에도 한글로 쓰는 것 같아 바로 한글로 내려주면 좋을 것 같아서 GenderType의 desc를 "woman" "man" 말고 "여자" "남자" 로 두면 어떨까요

ziiyouth
ziiyouth approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@ziiyouth ziiyouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨슴돡 🫡

src/main/java/org/gachon/checkmate/domain/post/dto/support/PostSearchCondition.java Show resolved Hide resolved
@RyuKwanKon RyuKwanKon merged commit 6576523 into develop Jan 6, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OJOJIN OJOJIN OJOJIN approved these changes

@ziiyouth ziiyouth ziiyouth approved these changes

Assignees

@RyuKwanKon RyuKwanKon

Labels
FEAT 새로운 기능을 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[fix] 성별 검색 필터 기능 추가
3 participants
@RyuKwanKon @OJOJIN @ziiyouth