Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] 스크랩, 내가 작성한 게시글 조회 api 구현 #36

Merged
merged 20 commits into from
Jan 11, 2024
Merged

[feat] 스크랩, 내가 작성한 게시글 조회 api 구현 #36

merged 20 commits into from
Jan 11, 2024

Conversation

RyuKwanKon
Copy link
Contributor

Related Issue 🪢

Summary 🌿

  • 게시물 개인 조회와 scrap 조회, 추가, 삭제 api 구현
  • custom paging 사용 여부에 따라 condition 관리
  • user state 추가 및 검색 조건 추가

Before i request PR review 🧤

  • 코드리뷰로 확인 부탁하는 사항

@RyuKwanKon
[feat] #34 내가 작성한 게시물 조회 api controller 구현
561544f
@RyuKwanKon
[feat] #34 내가 작성한 게시물 조회 api service 구현
17d622a
@RyuKwanKon
[fix] #34 게시물 조회 쿼리를 custom paging과 spring paging 사용여부로 구분
004effa
@RyuKwanKon
[feat] #34 spring paging 사용 조회 condition 구현
2fb0319
@RyuKwanKon
Merge remote-tracking branch 'origin/develop' into feature/34-post
68a260d
@RyuKwanKon
[feat] #34 scrap mapping 관계 정의
0503746
@RyuKwanKon
[feat] #34 scrap crd api controller 구현
5313b7a
@RyuKwanKon
[feat] #34 scrap crd api service 구현
9489190
@RyuKwanKon
[feat] #34 user 상태 관리 enum 추가
4f26b0f
@RyuKwanKon
[feat] #34 scrap 검색 조건 객체 구현
29d99ec
@RyuKwanKon
[feat] #34 scrap 생성 request dto 구현
7373838
@RyuKwanKon
[feat] #34 scrap query dsl 추상화 및 구현
78a6fa3
@RyuKwanKon
[feat] #34 scrap jpa repository 및 custom repository 추상화
6fbe42e
@RyuKwanKon
[feat] #34 유저 상태 관리에 따른 조회 조건 추가
b025c82
@RyuKwanKon
[fix] #34 게시글 생성 response header 변경
b426f79
@RyuKwanKon RyuKwanKon added the FEAT 새로운 기능을 추가 label Jan 11, 2024
@RyuKwanKon RyuKwanKon self-assigned this Jan 11, 2024
OJOJIN
OJOJIN reviewed Jan 11, 2024
View reviewed changes
Copy link
Contributor

@OJOJIN OJOJIN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

코멘트 남겼습니다! 확인 부탁드려요 수고하셨습니당👍

src/main/java/org/gachon/checkmate/domain/post/repository/PostCustomRepositoryImpl.java Outdated Show resolved Hide resolved
src/main/java/org/gachon/checkmate/domain/scrap/repository/ScrapCustomRepositoryImpl.java Outdated Show resolved Hide resolved
src/main/java/org/gachon/checkmate/domain/scrap/repository/ScrapCustomRepositoryImpl.java Outdated Show resolved Hide resolved
ziiyouth
ziiyouth approved these changes Jan 11, 2024
View reviewed changes
Copy link
Member

@ziiyouth ziiyouth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 !!! 추가로 상세 조회할 때 스크랩 여부도 추가해줘야 할 거 가태여!!

OJOJIN
OJOJIN approved these changes Jan 11, 2024
View reviewed changes
Copy link
Contributor

@OJOJIN OJOJIN left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고수고하셨습니다👍

@RyuKwanKon RyuKwanKon merged commit 42be45f into develop Jan 11, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OJOJIN OJOJIN OJOJIN approved these changes

@ziiyouth ziiyouth ziiyouth approved these changes

Assignees

@RyuKwanKon RyuKwanKon

Labels
FEAT 새로운 기능을 추가
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feat] 스크랩, 내가 작성한 게시글 조회 api 구현
3 participants
@RyuKwanKon @OJOJIN @ziiyouth