[fix] 정렬기준 default 값 변경 #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OJOJIN
approved these changes
Jan 18, 2024
| public enum CallType implements EnumField { | ||
| OUTSIDE("1", "밖에서"), | ||
| INSIDE("2", "안에서"), | ||
| ANYWAY("3", "상관없음"); |
There was a problem hiding this comment.
기획적인 의견이긴한데..
- 밖에서
- 5분 이내는 안에서
- 상관없음
로 나누는건 어떤가요? 현재는 2번과 3번이 둘이 비슷해보여서 의견드립니당
There was a problem hiding this comment.
음 뭔가 딱 와 닿는게 없어서 회의 때 말 해볼까요?? 저도 뭔가 딱 기준이 안세워지네요
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue 🪢
Summary 🌿
Before i request PR review 🧤