Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the
grainColumnName
as optional in thePhoenixChartDataColumn
interface as it was causing errors when initializing ChartData objects.The documentation has multiple spots where objects using this interface's structure are shown but the
grainColumnName
field was missing. A customer run into errors while creating charts, following the steps in the docs.e.g. https://domoapps.github.io/domo-phoenix/#/domo-phoenix/framework/react where
type
,name
, andmapping
are correctly listed, but notgrainColumnName
.Since
grainColumnName
seems to be linked todateGrain
, we're thinking it can be marked as optional instead.If it is actually meant to be required, we'll need to update the docs.
-- Bug reported by @WaldoMarais