Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set grainColumnName as optional #29

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

diazd2
Copy link

@diazd2 diazd2 commented Oct 11, 2023

Setting the grainColumnName as optional in the PhoenixChartDataColumn interface as it was causing errors when initializing ChartData objects.

The documentation has multiple spots where objects using this interface's structure are shown but the grainColumnName field was missing. A customer run into errors while creating charts, following the steps in the docs.

e.g. https://domoapps.github.io/domo-phoenix/#/domo-phoenix/framework/react where type, name, and mapping are correctly listed, but not grainColumnName.

Since grainColumnName seems to be linked to dateGrain, we're thinking it can be marked as optional instead.

If it is actually meant to be required, we'll need to update the docs.

-- Bug reported by @WaldoMarais

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant