-
Notifications
You must be signed in to change notification settings - Fork 44
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix
run erroneously using local environment variable
The local env var should only be given precedence when `--preserve-env` is specified. This also simplifies the key reconciliation logic a bit.
- Loading branch information
1 parent
c298514
commit 492c67e
Showing
4 changed files
with
118 additions
and
39 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,73 @@ | ||
| #!/bin/bash | ||
|
|
||
| set -euo pipefail | ||
|
|
||
| TEST_NAME="run" | ||
|
|
||
| cleanup() { | ||
| exit_code=$? | ||
| if [ "$exit_code" -ne 0 ]; then | ||
| echo "ERROR: '$TEST_NAME' tests failed during execution" | ||
| afterAll || echo "ERROR: Cleanup failed" | ||
| fi | ||
|
|
||
| exit "$exit_code" | ||
| } | ||
| trap cleanup EXIT | ||
|
|
||
| beforeAll() { | ||
| echo "INFO: Executing '$TEST_NAME' tests" | ||
| "$DOPPLER_BINARY" run clean --max-age=0s --silent | ||
| } | ||
|
|
||
| beforeEach() { | ||
| "$DOPPLER_BINARY" run clean --max-age=0s --silent | ||
| } | ||
|
|
||
| afterAll() { | ||
| echo "INFO: Completed '$TEST_NAME' tests" | ||
| "$DOPPLER_BINARY" run clean --max-age=0s --silent | ||
| } | ||
|
|
||
| error() { | ||
| message=$1 | ||
| echo "$message" | ||
| exit 1 | ||
| } | ||
|
|
||
| beforeAll | ||
|
|
||
| beforeEach | ||
|
|
||
| # verify local env is ignored | ||
| config="$(DOPPLER_CONFIG=123 "$DOPPLER_BINARY" run --config prd_e2e_tests -- printenv DOPPLER_CONFIG)" | ||
| [[ "$config" == "prd_e2e_tests" ]] || error "ERROR: conflicting local env var is not ignored" | ||
|
|
||
| beforeEach | ||
|
|
||
| # verify local env is used when specifying --preserve-env | ||
| config="$(DOPPLER_CONFIG=123 "$DOPPLER_BINARY" run --config prd_e2e_tests --preserve-env -- printenv DOPPLER_CONFIG)" | ||
| [[ "$config" == "123" ]] || error "ERROR: conflicting local env var is not used with --preserve-env" | ||
|
|
||
| beforeEach | ||
|
|
||
| # verify local env is used when key isn't specified in Doppler | ||
| value="$(NONEXISTENT_KEY=123 "$DOPPLER_BINARY" run -- printenv NONEXISTENT_KEY)" | ||
| [[ "$value" == "123" ]] || error "ERROR: local env var is not used" | ||
|
|
||
| beforeEach | ||
|
|
||
| # verify local env is used when key isn't specified in Doppler (and --preserve-env is specified) | ||
| value="$(NONEXISTENT_KEY=123 "$DOPPLER_BINARY" run --preserve-env -- printenv NONEXISTENT_KEY)" | ||
| [[ "$value" == "123" ]] || error "ERROR: local env var is not used with --preserve-env" | ||
|
|
||
| beforeEach | ||
|
|
||
| # verify reserved secrets are ignored | ||
| # first verify the doppler config has a secret named 'HOME', or this test is useless | ||
| "$DOPPLER_BINARY" secrets get HOME >/dev/null 2>&1 || error "ERROR: doppler config does not contain 'HOME' secret" | ||
| home="$HOME" | ||
| value="$("$DOPPLER_BINARY" run -- printenv HOME)" | ||
| [[ "$value" == "$home" ]] || error "ERROR: reserved secret is not ignored" | ||
|
|
||
| afterAll |