Pull request for #16 #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates a `pkg/drmem_provider` directory which will hold the code for a DrMem widget. The `.graphql` files have been moved and the build tools create the generated code in the correct spot.
This widget handles connections to all registered nodes.
This allows the data field to render differently when the device is settable.
Boolean values were rendered using `CheckBox` widgets. This had several issues: - It rendered differently on different platforms. - On Android, for instance, the adding and removing of the check was animated and fast-changing booleans weren/t getting displayed accurately. With this commit, we use `Icons` to visualize the state.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request will stay open until we complete #16. But this initial push is the first step in completing it. With this pull-request, all the GraphQL queries/subscriptions have been moved into a single module that defines a DrMem "provider" widget.
Further progress on this PR will have the widget removed from this project and moved into a Flutter package so any app can use it.