LAGraph: Adapt for stricter implementations of the OpenMP standard. #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IIUC, the OpenMP standard requires that the iterator of parallel for loops is a signed integer that is declared outside the scope of the parallel loop body. Some implementations seem to have relaxed that requirement. But others (MSVC) seem to use that strict interpretation.
|
Looks like the CI is going to be green again with this change. 🎉 |
|
Thanks! Yes, those "for (int k = .." loops don't work on Windows. I'm not sure how those slipped through our CI on the LAGraph repo itself. I knew about that but this LAGraph code was written by lots of people (I wrote the sort though so that's my bad). I wasn't aware that OpenMP required the for loop variable to be a signed integer. I'll have to double check my many parallel for loops in GraphBLAS (340 of them!); I tend to use signed integers but an unsigned might have slipped through. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IIUC, the OpenMP standard requires that the iterator of parallel for loops is a signed integer that is declared outside the scope of the parallel loop body. Some implementations seem to have relaxed that requirement (allowing unsigned integers or initialization in the for loop). But others (MSVC) seem to follow a stricter interpretation of the standard.
Adapt the source to allow for that stricter interpretation.
Fixes the second issue raised in #462.