Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u3d/unity_versions: list from additional U3D_ADDITIONAL_PAGES #334

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

niezbop
Copy link
Member

@niezbop niezbop commented Dec 3, 2018

Pull Request Checklist

  • My pull request has been rebased on master
  • I ran bundle exec rspec to make sure that my PR didn't break any test
  • I ran bundle exec rubocop to make sure that my PR is inline with our code style
  • I have read the code of conduct

Pull Request Description

This adds the ability to list unity versions from sources other than the one preconfigurated in u3d, through an environment variable U3D_ADDITIONAL_PAGES. This allows for greater flexibility and compensates recent changes on the Unity website that prevent us from listing beta versions.

Sample output:

$ U3D_ADDITIONAL_PAGES=https://unity3d.com/unity/beta/2018.3 u3d available -f --no-central
Cache is out of date. Updating cache for Windows
Loading Unity lts releases
Found 17 lts releases.
Loading Unity stable releases
Found 105 stable releases.
Loading Unity patch releases
Found 191 patch releases.
Loading Unity beta releases
Found 1 beta releases.
Loading Unity custom releases
Found 1 custom releases.
[...]
Version 2018.2.16f1: https://download.unity3d.com/download_unity/39a4ac3d51f6/
Version 2018.2.17f1: https://download.unity3d.com/download_unity/88933597c842/
Version 2018.2.18f1: https://netstorage.unity3d.com/unity/4550892b6062/
Version 2018.3.0b12: http://beta.unity3d.com/download/77f6238a7ced/

Note the last build, the 2018.3.0b12 which was not accessible before that.

@niezbop
Copy link
Member Author

niezbop commented Dec 3, 2018

This could address the issues brought in #330 and related

@niezbop niezbop self-assigned this Dec 3, 2018
@niezbop
Copy link
Member Author

niezbop commented Dec 5, 2018

This is kind of replaced by #335 as a fix for #330 but this still could be a useful feature

@KonH
Copy link

KonH commented Jul 4, 2019

Hello, @niezbop! As I see, this PR can resolve this issue - #360. Unfortunately, it isn't merged yet and it looks like the project is abandoned or something like that. I will try to build it from scratch based on your branch (but don't have experience with it), but it will be helpful if this PR will be merged in the future.

KonH added a commit to KonH/UnityCiPipeline that referenced this pull request Jul 4, 2019
@KonH
Copy link

KonH commented Jul 4, 2019

I've tried your branch, but it shows less available versions (I add U3D_ADDITIONAL_PAGES=https://unity3d.com/unity/beta/2018.3 to get previously available, but can't get wanted versions).
Then I've tried to cherry-pick your changes over this repo master branch, but didn't sure how exactly I need to solve merge conflicts.
Can you please give me some advices? My goal is get 2019.1+ versions on Linux, which isn't available now.

@niezbop
Copy link
Member Author

niezbop commented Jul 4, 2019

Hey @KonH ! The project is still alive! We are still using u3d on a daily basis and have no plan to drop support for it 😄 Unfortunately we have had tight deadlines to hold since and no time to spend on this project.
I'll take a swing at this soon, and hopefully solve a bit your issue.

@niezbop niezbop force-pushed the feature/custom_download_page branch from 6cbeb01 to ca5deab Compare July 4, 2019 16:01
@niezbop
Copy link
Member Author

niezbop commented Jul 4, 2019

So the pull request has no longer any conflicts. It's still not complete in my mind since it does not support Linux yet. I'll open a quick fix for #360 using another strategy, but this could still be finished. Or at least should be closed. WDYT @lacostej ?

@niezbop niezbop requested a review from lacostej November 4, 2019 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants