-
-
Notifications
You must be signed in to change notification settings - Fork 142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(mm): 修复fat文件系统的PageCache同步问题 #1005
Open
MemoryShore
wants to merge
19
commits into
DragonOS-Community:master
Choose a base branch
from
MemoryShore:patch-fix-pagecache
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+513
−143
Open
Changes from 12 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
add9d4b
实现read系统调用读取pagecache
MemoryShore d2ad608
完善read逻辑
MemoryShore 60e36ca
完善create_pages
MemoryShore 773e36d
添加read_direct
MemoryShore f99aec5
解决create_pages时的死锁问题
MemoryShore 032db07
修复元数据未更新的问题
MemoryShore 19ea62b
Merge branch 'master' into patch-fix-pagecache
MemoryShore 8365ca3
重构read逻辑
MemoryShore acc821a
重写write逻辑
MemoryShore 7d13a5b
修正页面回写逻辑
MemoryShore f97b0b7
Merge branch 'master' into patch-fix-pagecache
MemoryShore 0553021
优化代码
MemoryShore 63bd233
优化代码
MemoryShore fd59c5b
Merge branch 'master' into patch-fix-pagecache
MemoryShore 1a7e9cc
修复lru链表缩减逻辑
MemoryShore 668a279
修正page_writeback逻辑
MemoryShore ec98b84
添加write_direct
MemoryShore 74c7059
Merge branch 'master' into patch-fix-pagecache
MemoryShore 7a3608b
完善页面释放逻辑
MemoryShore File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个为啥删了?这个是用来更新读取时间的。(只是现在还没实现)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个方法会把inode记录的size跟磁盘的size同步导致错误,我看看是不是要修改一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
啊哈,这又是什么bug哈哈
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
就是说,如果启用pagecache的话inode的size跟fat文件的size不是保持一致的,但是这个方法会直接让inode的size更新为fat的size导致用户态获取的文件大小不正确
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
哦哦,那最终回写的时候就会把它弄成一致的,对吧?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
对的,不过如果需要更新读取时间的话感觉不能直接删掉,而是要修改一下方法的逻辑,不能直接把size同步
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
确实