feat(namespace) feat some namespace bugs #1033
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
codeironman
commented
Nov 7, 2024
codeironman
commented
- remove contains_of ! Macro
- fix some bugs
主要完善实现了pid_namespace 基本实现了mnt_namespace 开始cgroup的架构设计
1. add overlayfs test 2. fix mount syscall 3. add setns syscall
|
@codeironman: no appropriate reviewer found, use |
github-actions
bot
added
the
ambiguous
fslongjin
requested changes
Nov 10, 2024
Comment on lines
28
to
41
| pub struct MntNamespace { | ||
| /// namespace 共有的部分 | ||
| ns_common: Arc<NsCommon>, | ||
| /// 关联的用户名字空间 | ||
| user_ns: Arc<UserNamespace>, | ||
| /// 资源计数器 | ||
| ucounts: Arc<UCounts>, | ||
| /// 根文件系统 | ||
| root: Option<Arc<MountFS>>, | ||
| /// 红黑树用于挂载所有挂载点 | ||
| mounts: RBTree<InodeId, MountFSInode>, | ||
| mounts: Arc<RBTree<InodeId, MountFSInode>>, | ||
| /// 等待队列 | ||
| poll: WaitQueue, | ||
| poll: Arc<WaitQueue>, | ||
| /// 挂载序列号 | ||
| seq: AtomicU64, | ||
| seq: Arc<AtomicU64>, | ||
| /// 挂载点的数量 |
There was a problem hiding this comment.
为什么每个成员变量都是Arc<>?这个访存效率低并且浪费内存。直接一个Arc<MntNamespace>会不会好些。
并且，mounts字段还有poll字段，你确定你测试过能用？？？？这个一眼看过去就知道跑不了。
| fn name(&self) -> String; | ||
| fn clone_flags(&self) -> CloneFlags; | ||
| fn get(&self, pid: Pid) -> Option<Arc<dyn Namespace>>; | ||
| fn put(&self); |
| } | ||
| fn get(&self, pid: crate::process::Pid) -> Option<Arc<dyn Namespace>> { | ||
| ProcessManager::find(pid) | ||
| .map(|pcb| pcb.get_nsproxy().read().mnt_namespace.clone() as Arc<dyn Namespace>) |
There was a problem hiding this comment.
get_nsproxy方法改名为nsproxy。这样比较符合rust的命名规范。
| return Err(SystemError::EINVAL); | ||
| } | ||
| nsproxy.mnt_namespace = mnt_ns; | ||
| nsproxy.mnt_namespace = Arc::new(self.clone()); |
There was a problem hiding this comment.
这里指向的根本就不是当前的namespace了啊。
你可能需要搜下我们代码里面的self_ref. 并且你还需要了解Arc指针跟Weak指针。因为类似这种写法就是错误的：
怎么能child存储指向父级的Arc呢？这显然是不正确的。
| @@ -1,4 +1,5 @@ | |||
| #![allow(dead_code, unused_variables, unused_imports)] | |||
| pub ucount_max: Vec<u32>, //vec![u32; UCOUNT_COUNTS as usize], | ||
| pub rlimit_max: Vec<u32>, // vec![u32; UCOUNT_RLIMIT_COUNTS as usize], | ||
| pub ucount_max: Vec<u32>, | ||
| pub rlimit_max: Vec<u32>, |
There was a problem hiding this comment.
我认为UserNamespace结构体本身就应该是个Arc的。并且这个创建Arc的过程应该在它的new方法里面体现出来。而不是依赖default方法，然后在外面才创建Arc.
Comment on lines
+45
to
+53
| Self { | ||
| id_alloctor: Arc::new(RwLock::new(IdAllocator::new(1, PID_MAX).unwrap())), | ||
| pid_allocated: 1, | ||
| level: 0, | ||
| child_reaper: Arc::new(RwLock::new(Pid::from(1))), | ||
| parent: None, | ||
| ucounts: Arc::new(UCounts::default()), | ||
| user_ns: Arc::new(UserNamespace::default()), | ||
| } |
There was a problem hiding this comment.
不应该依赖default方法。并且
Ucounts的Usernamespace和这里的user_ns都不是同一个userNamespace
这个很显然是有问题的。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.