实现了对用户空间传入指针抽象的UserBufferReader/Writer，来检验用户空间指针地址并提供一定的功能抽象 #326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fslongjin
requested changes
Aug 12, 2023
kernel/src/libs/userbuffer.rs
Outdated
| /// @return 构造成功返回UserbufferReader实例，否则返回错误码 | ||
| /// | ||
| pub fn new(addr: *const T, len: usize) -> Result<Self, SystemError> { | ||
| if unsafe { !verify_area(addr as u64, (len * core::mem::size_of::<T>()) as u64) } { |
There was a problem hiding this comment.
这个verify area不要使用C的，rust版本之前有写过，参考syscall/syscall.rs
kernel/src/libs/userbuffer.rs
Outdated
|
|
||
| #[derive(Debug)] | ||
| pub struct UserBufferReader<T> { | ||
| addr: *const T, |
There was a problem hiding this comment.
这里可以直接存储数组的引用，这样能够更安全。
现在这样，直接存裸指针的话，后面每次读取，都手动转数组引用。实际上是在一定程度上绕过了借用检查
然后我感觉从通用性考虑，这里完全可以转为&[u8]
在读取函数那里，可以允许通过任意的类型来解析它。这样会更好。
…into userbuffer-dev
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.