Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After shipping 0.17.1, in Sentry I started to notice errors that looked like this
Taking a closer look at things, the JavaScript was doing a check that it should not need to any more.
The
valueChangedHandler
was worried about whether we were in mulit-select mode and if it was the initial value. We're taking care of that logic in Elm now which should be the single source of truth on that stuff.So let's just remove those checks
I also found some broken example in the site which I fixed too.
Also I added some follow up issues:
These are related bit of logic that should be tracked in Elm too and should just be handed out to the JavaScript.