Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Value Changed Error Message #220

Merged
merged 5 commits into from
Jan 30, 2023
Merged

Conversation

jachin
Copy link

@jachin jachin commented Jan 30, 2023

After shipping 0.17.1, in Sentry I started to notice errors that looked like this

In single select mode we are expecting a single value, instead we got 2

Taking a closer look at things, the JavaScript was doing a check that it should not need to any more.

The valueChangedHandler was worried about whether we were in mulit-select mode and if it was the initial value. We're taking care of that logic in Elm now which should be the single source of truth on that stuff.

So let's just remove those checks

I also found some broken example in the site which I fixed too.

Also I added some follow up issues:

These are related bit of logic that should be tracked in Elm too and should just be handed out to the JavaScript.

@jachin jachin added the bug Something isn't working label Jan 30, 2023
@jachin jachin self-assigned this Jan 30, 2023
@jachin jachin changed the title Hooking up value change to different ports depending on whether it's Value Changed Error Message Jan 30, 2023
@jachin jachin merged commit 058e99b into master Jan 30, 2023
@jachin jachin deleted the value-changed-handler-doing-too-much branch January 30, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant