Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[predictive-back-navigation] remove deprecated method calls in activities #771

Closed
wants to merge 3 commits into from

Conversation

lunaticare
Copy link
Contributor

@lunaticare lunaticare commented Jul 9, 2024

Copy link

what-the-diff bot commented Jul 9, 2024

PR Summary

  • Introduction of App Level Back Button Control in ScreenActivity
    Implemented a new functionality setUpBackHandler() in ScreenActivity.kt, this will provide us with a precise control over the behavior of the back button in the entire app.

  • Modification in ScreenActivity's Existing Functions

    • Adjusted onBackPressed() function for implementing a more controlled navigation experience on the back button press.
    • The onToolbarCreated() function was modified for better compatibility with the new back button navigation process.
  • Changes in EditRepositoryFragment
    Adjusted the onBackPressed() function to improve the navigation experience when editing the repositories.

  • Adjustment in RepositoryFragment
    The onDeleteConfirm() function has been refined. It now better handles the situations after the user confirms to delete a repository.

  • Updation in SettingsFragment
    Modified the toolbar.setNavigationOnClickListener() function to ensure the back button in toolbar behaves correctly during setting adjustments.

  • Updates to File Permissions
    Changed the access permissions for gradlew file from mode 100644 to 100755. This update is done to solve potential issues regarding file access rights and execution permissions.

@Iamlooker
Copy link
Member

Have you tested these changes?

@lunaticare
Copy link
Contributor Author

lunaticare commented Jul 9, 2024

Have you tested these changes?

Yes. I will add a couple more commits on top, but each pull request should be fully working, i.e. is does not break back navigation. I will add a test plan in the final PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants