Replace hardcoded contentDescription attribute

DroidKaigi · Jan 20, 2019 · 00e3008 · 00e3008
1 parent 56d5a24
commit 00e3008
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 1 deletion.
diff --git a/feature/staff/src/main/res/layout/item_staff.xml b/feature/staff/src/main/res/layout/item_staff.xml
@@ -27,7 +27,7 @@
             android:layout_marginBottom="8dp"
             android:layout_marginStart="16dp"
             android:layout_marginTop="8dp"
-            android:contentDescription="aaa"
+            android:contentDescription="@string/staff_image_description"
             app:layout_constraintBottom_toBottomOf="parent"
             app:layout_constraintStart_toStartOf="parent"
             app:layout_constraintTop_toTopOf="parent"

diff --git a/feature/staff/src/main/res/values-ja/strings.xml b/feature/staff/src/main/res/values-ja/strings.xml
@@ -1,4 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <string name="staff_search_hint">検索する…</string>
+    <string name="staff_image_description">スタッフ</string>
 </resources>
diff --git a/feature/staff/src/main/res/values/strings.xml b/feature/staff/src/main/res/values/strings.xml
@@ -1,4 +1,5 @@
 <?xml version="1.0" encoding="utf-8"?>
 <resources>
     <string name="staff_search_hint">Search…</string>
+    <string name="staff_image_description">Committee member</string>
 </resources>