Add staff list page #557
Add staff list page #557
Conversation
|
Your app is deployed! Try it via https://deploygate.com/distributions/9e73d0e587425e452fdab3d27ffa6a5344fc0abd |
|
🆒 |
| android:layout_marginBottom="8dp" | ||
| android:layout_marginStart="16dp" | ||
| android:layout_marginTop="8dp" | ||
| android:contentDescription="aaa" |
There was a problem hiding this comment.
Hardcoded string “aaa”, should use @string resource |
|
Sorry, we have to focus on developing the function of the session questionnaire so it will be a little late. 🙇 |
|
The search function is very cool🆒 |
| withContext(coroutineContext) { | ||
| database.runInTransaction { | ||
| val staffs = apiResponse.staffs.toStaffEntities() | ||
| staffDao.insert(staffs) |
There was a problem hiding this comment.
Maybe we should use "deleteAll()" before insert(). Because If someone quits the staff for some reason, it seems to remain. 👀
There was a problem hiding this comment.
That's a good catch 💯
| import io.github.droidkaigi.confsched2019.staff.databinding.ItemStaffBinding | ||
| import jp.wasabeef.picasso.transformations.CropCircleTransformation | ||
|
|
||
| class StaffItem constructor( |
|
Almost LGTM 👍 |
|
Your app is deployed! Try it via https://deploygate.com/distributions/9e73d0e587425e452fdab3d27ffa6a5344fc0abd |
|
Your app is deployed! Try it via https://deploygate.com/distributions/9e73d0e587425e452fdab3d27ffa6a5344fc0abd |
|
Your app is deployed! Try it via https://deploygate.com/distributions/9e73d0e587425e452fdab3d27ffa6a5344fc0abd |
Apk comparision results
Generated by 🚫 Danger |
|
Asserted successfully. 💯 Generated by 🚫 Danger |
|
@takahirom Thanks a lot for your support and for the opportunity to contribute :) |
Issue
Overview (Required)
Screenshot