Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Sponsor ActionCreator test #751

Merged

Conversation

xnxaxo
Copy link
Contributor

@xnxaxo xnxaxo commented Feb 2, 2019

Issue

Overview (Required)

  • Add test for SponsorActionCreator
  • Refer to SponsorActionCreatorTest

Links

Screenshot

@jmatsu-bot
Copy link
Collaborator

DateTime.createAdjusted(2019, 2, 7, 10, 0).toOffsetUnadjusted(9.hours).utc

fun dummySponsorsData(): List<SponsorCategory> {
fun dummySponsorCategoriesData():List<SponsorCategory> {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Missing spacing after “:”

@jmatsu-bot
Copy link
Collaborator

Apk comparision results

Property Summary
New File Size 8357998 Bytes. (7.97 MB)
File Size Change +122 Bytes. (+0.12 KB)
Download Size Change +142 Bytes. (+0.14 KB)
New Method Reference Count 61204
Method Reference Count Change 0
New Number of dex file(s) 1
Number of dex file(s) Change 0

Generated by 🚫 Danger

@jmatsu-bot
Copy link
Collaborator

Asserted successfully. 💯

Generated by 🚫 Danger


sponsorActionCreator.load()

coVerify(ordering = Ordering.ORDERED) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I love this coVerify. 😄

Copy link
Member

@takahirom takahirom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@takahirom takahirom merged commit f553e78 into DroidKaigi:master Feb 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Sponsor ActionCreator test
3 participants