-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add laravel 11 support and improve test quality #35
Merged
Dropelikeit
merged 17 commits into
master
from
feature/add-laravel-11-support-and-improve-test-quality
May 13, 2024
Merged
Feature/add laravel 11 support and improve test quality #35
Dropelikeit
merged 17 commits into
master
from
feature/add-laravel-11-support-and-improve-test-quality
May 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…zer/FactoryTest This commit updates the version numbers of several dependencies in composer.json and performs a significant refactoring of ResponseFactoryTest and Serializer/FactoryTest. The changes in ResponseFactoryTest include refactoring the test names and adding new test methods. At the same time, additional test methods were added and existing methods were revised. A new file, XmlDummy.php, is also created for testing purposes.
…zer/FactoryTest This commit updates the version numbers of several dependencies in composer.json and performs a significant refactoring of ResponseFactoryTest and Serializer/FactoryTest. The changes in ResponseFactoryTest include refactoring the test names and adding new test methods. At the same time, additional test methods were added and existing methods were revised. A new file, XmlDummy.php, is also created for testing purposes.
This commit increases the php-cs-fixer version in the composer.json file from "^3.51" to "^3.52". Furthermore, the support note section in the README.md file has been revised to present supported Laravel and PHP versions in a more detailed tabulated format.
The versions for Laravel 11 and 10 packages were updated in the support note section. Package version for Laravel 11 was changed to v6.x.x, and for Laravel 10 was updated to indicate it now supports versions greater than or equal to v5.x.x.
The CI workflow in Github has been simplified by removing coverage and coveralls, and modifying the composer test command execution. The PHP version in composer.json was updated to include PHP 8.3.
The CI workflow has been updated to reflect changes in the file path and caching keys for more specific PHP versions (8.1, 8.2, 8.3). The changes were made in the composer test command execution in the .github/workflows/ci.yml file.
The "actions/checkout" action version has been updated from v3 to v4 in the CI workflow file (.github/workflows/ci.yml). This change applies to multiple steps in the file, making the workflow use the more recent version of the action during the Checkout process.
The tests have been restructured and json response has been enhanced. All test-related things within the "ResponseFactory" directory have been moved to a new "data" directory. Also, the composer.json file and ServiceProvider.php have been updated with new dependencies and adjustments. Updates to ResponseFactoryTest.php now allow JSON responses as well.
The .gitignore file was modified to optimize it for the project's current needs. Unnecessary Laravel specific ignores were removed and PHPUnit, Composer, and Package specific ignores were added. This change will ensure that irrelevant files are not tracked by the version control system.
The commit involves the removal of several unused lines of constants and code from ResponseFactory and composer.json. In addition, tests have also been updated to assert the instance type of ResponseFactory whenever it's gotten from the application container. Improvements were made to the type annotations in the ResponseFactory tests for clarity.
The CI workflow has been updated to use the latest version of actions/cache (v4) for caching composer packages. This change was made in the configurations for PHP versions 8.1, 8.2, and 8.3 to ensure consistent usage of the updated cache action across all versions.
Updated composer.json to enhance PHPUnit test coverage options and added 'infection-ci' for CI testing. Modified CI workflow to use 'infection-ci' for more efficient infection testing across different PHP versions.
The command for running tests in the CI workflow file has been changed from "composer test" to "composer test-coverage". This will aid in providing more detailed test coverage reports during the continuous integration process, thus helping in identifying untested areas of code and improving overall code quality and reliability.
An addition was made to the CI workflow file to include triggers on push events to the main branch. Providing continuous integration support for the main branch will help ensure code stability and quality.
The commit removes the Coveralls report generation from the GitHub Actions workflow. Now, the workflow only executes the test coverage without performing the extra steps for Coveralls report generation. This streamlines the GitHub Actions process by reducing complex steps.
Reduced the number of threads used by the 'infection-ci' command in the composer.json file. The change decreases the thread usage from 16 to 4, which may impact the execution speed but helps to reduce resource consumption.
Dropelikeit
deleted the
feature/add-laravel-11-support-and-improve-test-quality
branch
May 13, 2024 12:36
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.