-
-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various Fixes #167
various Fixes #167
Conversation
* test1 * test2 * test3 * test4 * test5 * autopy test
…installed automatically now
@DutchmanNL would you mind taking a look? |
thank you remaindering me, WoW !!! Awesome dude, you ROCK ! I will review and test it this week but it looks already awesome and safes me a lot of stuff on my side Are you reachable on discord or Telegram to discuss if any questions occur or should we keep it here |
I'm technically open to dicussing on telegram / discord. |
Thanks for reviewing and merging. Please create a new release also. |
Thank you for your input, appreciated! I didn't see any strange thinks and indeed solution you made with separate state creation fits design of the structure. Running some test now at my home installation and would like to solve the spam errors if a device disconnects and than I will release a new version to NPM I expect that will be somewhere end of the week. Is it ok for you if I include your name for the fixes into the readme ? You deserve the credits!! |
@SimonFischer04 hmm looks like we have an issue, at least on my side. The ESPHome dashboard proces is not working anymore, did you encounter any issues with that ? |
No problem. Just thought (and was also bit surprised you supposedly did so quick) you already tested as you already merged. Would have been also possibly to test by directly installing the adapter from my branch in iobroker. |
Yes, would be pleased. |
as for one of this logs see: #170 :) other than that just tested (as already before) again using the direct install from url feature on my test-vm using the new changes on main branch here and dashboard works for me. Do you mean that it actually does not work for you or just the log-entry? |
It was not working for me at all anymore (Adapter yes but dashboard not) will deep dive a little more into it and try to reproduce. Maybe it’s indeed just my installation for some reason |
so you just get a 404 when trying to access the dashboard on you own installation? |
This PR includes various fixes / improvements: