Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Device Type Select #172

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Device Type Select #172

merged 1 commit into from
Oct 28, 2023

Conversation

SimonFischer04
Copy link
Contributor

Waiting for original poster feedback in #169 - therefore draft for now.

Copy link
Contributor

@DutchmanNL DutchmanNL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicely solved and code wel understood respect! Indeed very good, as information select menu is already available in API data, to use that directly to generate a dropdown instead of stateAttr entry.

thank you

@DutchmanNL
Copy link
Contributor

thank you! Lets wait for feedback from @patricknitsch before merging :)

@DutchmanNL
Copy link
Contributor

@SimonFischer04 ready to be merged or would you like to test/update some additional stuff?

@SimonFischer04 SimonFischer04 marked this pull request as ready for review October 28, 2023 09:03
@SimonFischer04
Copy link
Contributor Author

@SimonFischer04 ready to be merged or would you like to test/update some additional stuff?

no i already tested myself. just wanted to make sure it works for / get feedback from @patricknitsch

@SimonFischer04
Copy link
Contributor Author

nstead of stateAttr entry

yes, already used that to implement button. but doesn't help here before the info is dynamic.

@DutchmanNL DutchmanNL merged commit f278189 into DrozmotiX:main Oct 28, 2023
@DutchmanNL
Copy link
Contributor

Merged as we got confirmation

I will make a new release end of the day

If time allows I will also include a first go for cleanup of offline devices we discussed in the other issue.

Based on that we can continue for channels & states

Will create a new Branche for that but first some go-karting with my children 😅

@SimonFischer04 SimonFischer04 deleted the fix/169 branch October 28, 2023 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding Type "Select" to ESP Home Adapter
2 participants