Remove constraint on uri pathname matching the...

configured redirectUri pathname. Closes mulesoft-labs#129
Druotic · Dec 27, 2019 · 6941e5c · 6941e5c
1 parent 8005fff
commit 6941e5c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 10 deletions.
diff --git a/src/client-oauth2.js b/src/client-oauth2.js
@@ -582,16 +582,6 @@ CodeFlow.prototype.getToken = function (uri, opts) {
 
   var url = typeof uri === 'object' ? uri : Url.parse(uri, true)
 
-  if (
-    typeof options.redirectUri === 'string' &&
-    typeof url.pathname === 'string' &&
-    url.pathname !== Url.parse(options.redirectUri).pathname
-  ) {
-    return Promise.reject(
-      new TypeError('Redirected path should match configured path, but got: ' + url.pathname)
-    )
-  }
-
   if (!url.query) {
     return Promise.reject(new TypeError('Unable to process uri: ' + uri))
   }

diff --git a/test/code.js b/test/code.js
@@ -36,6 +36,15 @@ describe('code', function () {
         })
     })
 
+    it('uri pathname and redirectUri pathname should not have to match', function () {
+      return githubAuth.code.getToken(uri, {
+        redirectUri: config.redirectUri + '/someOtherJunk'
+      })
+        .then(function (user) {
+          expect(user.accessToken).to.equal(config.accessToken)
+        })
+    })
+
     it('should reject with auth errors', function () {
       var errored = false