Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #692 pfp edit button placement #734

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix #692 pfp edit button placement #734

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/routes/(app)/members/[studentId]/+page@(app).svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@
{#if canEdit}
<a
href="{studentId}/profile-picture"
class="btn btn-square glass btn-primary btn-sm absolute left-1/2 top-2 origin-center !-translate-x-1/2"
class="btn btn-circle glass btn-primary btn-sm absolute bottom-2 right-0 origin-center !-translate-x-1/2"
>
<span class="i-mdi-edit" />
<span class="i-mdi-edit absolute bottom-[0.6rem] right-[0.6rem]" />
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! Some comments/thoughts:
I think we should try to use the built-in "sizes" as much as possible, for example bottom-2 is the same as bottom-[0.5rem].
Also, can't this be centered?
And lastly, since you're a developer you don't need to work from a fork! You can create branches in the main repo directly :)

</a>
{/if}
</MemberAvatar>
Expand Down