-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nollning CMS #745
Open
Isak-Kallini
wants to merge
6
commits into
main
Choose a base branch
from
directus-example
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Nollning CMS #745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Overview
This PR integrates Directus CMS into the project by introducing functions to fetch page and collection data, adding new Docker services for CMS components, and updating dependencies.
- Adds Directus instance helper functions and data fetching utilities in src/lib/server/directus.ts
- Updates docker-compose.yml to configure CMS-related services (Postgres, Directus)
- Updates pnpm-lock.yaml with new Directus SDK version and updates the server route for nollning content in +page.server.ts
Reviewed Changes
File | Description |
---|---|
src/lib/server/directus.ts | Implements Directus instance and data fetching functions |
docker-compose.yml | Introduces cms_db and directus services for CMS integration |
pnpm-lock.yaml | Updates Directus SDK dependency version |
src/routes/(nollning)/nollning/+page.server.ts | Uses new Directus functions to load CMS content and collections |
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #707
This pr adds the CMS called Directus.
There are some quirks right now, most importantly you need to add languages in the language collection for the other collections to work correctly
Should probably not be merged until Directus is set up in production so we don't break the current nollning page