Add Verifiable Message Signing #360
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvinwang
reviewed
Oct 9, 2025
kvinwang
reviewed
Oct 16, 2025
Comment on lines
+236
to
+238
| message SignResponse { | ||
| bytes signature = 1; | ||
| } |
There was a problem hiding this comment.
Suggested change
| message SignResponse { | |
| bytes signature = 1; | |
| } | |
| message SignResponse { | |
| // the signature of the data | |
| bytes signature = 1; | |
| // The signature chain consists of the following signatures: | |
| // [0] - the signature of the data | |
| // [1] - the k256 signature of the message signing pubkey signed by the app root key | |
| // [2] - the k256 signature of the app root pubkey signed by the KMS root key | |
| repeated bytes signature_chain = 2; | |
| // The public key signing the data | |
| bytes public_key = 3; | |
| } |
The signature_chain[1:2] can be optained from the response of GetKey.
kvinwang
reviewed
Oct 16, 2025
| // Derived key | ||
| bytes key = 1; | ||
| // Derived k256 signature chain | ||
| // Derived signature chain |
There was a problem hiding this comment.
Suggested change
| // Derived signature chain | |
| // The signature chain consists of the following signatures: | |
| // [0] - the k256 signature of the derived pK signed by the app root key | |
| // [1] - the k256 signature of the app root pK signed by the KMS root key |
kvinwang
reviewed
Oct 16, 2025
Comment on lines
+316
to
+328
| let key_response = self | ||
| .get_key(GetKeyArgs { | ||
| path: "vms".to_string(), | ||
| purpose: "signing".to_string(), | ||
| algorithm: "ed25519".to_string(), | ||
| }) | ||
| .await?; | ||
| let key_bytes: [u8; 32] = | ||
| key_response.key.try_into().expect("Key is incorrect"); | ||
| Ed25519SigningKey::from_bytes(&key_bytes) | ||
| .verifying_key() | ||
| .to_bytes() | ||
| .to_vec() |
There was a problem hiding this comment.
This may be unnecessary. Typically, CVM1 signs a message for verification in CVM2.
kvinwang
reviewed
Oct 16, 2025
Comment on lines
+340
to
+349
| let key_response = self | ||
| .get_key(GetKeyArgs { | ||
| path: "vms".to_string(), | ||
| purpose: "signing".to_string(), | ||
| algorithm: request.algorithm, | ||
| }) | ||
| .await?; | ||
| let signing_key = SigningKey::from_slice(&key_response.key) | ||
| .context("Failed to parse secp256k1 key")?; | ||
| signing_key.verifying_key().to_sec1_bytes().to_vec() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.