Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warn when non-distributed cache detected #1550

Merged
merged 2 commits into from
May 24, 2024

Conversation

AndersAbel
Copy link
Member

@AndersAbel AndersAbel commented May 6, 2024

Log (info level) if OIDC state data formatter is enabled with in memory distributed cache.

I've had a few cases in support where the Oidc state data formatter has been enabled but the distributed cache is the default memory based version. IdentityServer (unfortunately?) adds the in memory implementation as a fallback so it is easy to miss this. A warning message similar to the ones we have for in memory persisted grants should help.

@AndersAbel AndersAbel force-pushed the anders/warn-non-distributed-cache branch from 937cca0 to 47728c4 Compare May 22, 2024 07:52
@AndersAbel AndersAbel marked this pull request as ready for review May 22, 2024 07:53
@AndersAbel AndersAbel changed the base branch from main to releases/7.0.x May 23, 2024 10:33
@AndersAbel AndersAbel force-pushed the anders/warn-non-distributed-cache branch from 47728c4 to 9735889 Compare May 23, 2024 10:39
@AndersAbel AndersAbel marked this pull request as draft May 24, 2024 06:55
@AndersAbel
Copy link
Member Author

Marking this as draft to keep it on hold until build issues in releases/7.0.x have been fixed.

@josephdecock josephdecock marked this pull request as ready for review May 24, 2024 14:16
@josephdecock josephdecock force-pushed the anders/warn-non-distributed-cache branch from 9735889 to 59738c9 Compare May 24, 2024 14:26
@josephdecock
Copy link
Member

The 7.0 release should be fixed now, yet the checks still failed? That was so weird that I rebased this branch to try again...

@josephdecock
Copy link
Member

Okay, not sure why a rebase was necessary, but it looks like the build works now. @AndersAbel - do we need this in a 7.0 patch release?

@AndersAbel AndersAbel merged commit a4d0c19 into releases/7.0.x May 24, 2024
3 checks passed
@AndersAbel AndersAbel deleted the anders/warn-non-distributed-cache branch May 24, 2024 21:31
@AndersAbel
Copy link
Member Author

@josephdecock I don't think we need a release just for this. I've had a couple of support cases caused by people running the OIDC Formatter with the in memory distributed cache. This will reduce the risk for people hitting that, but it can go with the next release.

@brockallen
Copy link
Member

Can we mark this with label and milestone?

@AndersAbel AndersAbel added enhancement New feature or request no release notes needed Usually applies to internal issues labels May 30, 2024
@AndersAbel AndersAbel added this to the 7.0.5 milestone May 30, 2024
@AndersAbel AndersAbel removed the no release notes needed Usually applies to internal issues label May 30, 2024
@brockallen brockallen changed the title Anders/warn non distributed cache Warn when non-distributed cache detected Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants