Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unhandled argument null exception for refresh_token grant in token validator when scopes missing #1595

Open
wants to merge 1 commit into
base: releases/7.0.x
Choose a base branch
from

Conversation

Bartizan
Copy link

What issue does this PR address?

On call to /connect/token endpoint, Identity Server returns an HTML page due to an internal error instead of a response in JSON format.
The related issue is created.

Important: Any code or remarks in your Pull Request are under the following terms:

If You provide us with any comments, bug reports, feedback, enhancements, or modifications proposed or suggested by You for the Software, such Feedback is provided on a non-confidential basis (notwithstanding any notice to the contrary You may include in any accompanying communication), and Licensor shall have the right to use such Feedback at its discretion, including, but not limited to the incorporation of such suggested changes into the Software. You hereby grant Licensor a perpetual, irrevocable, transferable, sublicensable, nonexclusive license under all rights necessary to incorporate and use your Feedback for any purpose, including to make and sell any products and services.

(see our license, section 7)

…sh_token grant in token validator when scopes missing
@Bartizan Bartizan marked this pull request as ready for review September 18, 2024 12:40
@josephdecock
Copy link
Member

Thanks for the PR! I wonder if this is the right place to solve the problem? It seems like creating a refresh token that can't be used ought to be invalid, so maybe we shouldn't even allow the refresh token to be created in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants