bff - Split StateProviderPollingInterval into separate options for WA…

…SM and Server

bff/docs/upgrade-guide.md

@@ -102,4 +102,9 @@ a custom IAccessTokenRetriever, then you should adjust their usage accordingly.
 
 ### AddAddEntityFrameworkServerSideSessionsServices has been renamed to AddEntityFrameworkServerSideSessionsServices
 
-If you used the method AddAddEntityFrameworkServerSideSessionsServices() in your code, please replace it with the corrected AddEntityFrameworkServerSideSessionsServices()
+If you used the method AddAddEntityFrameworkServerSideSessionsServices() in your code, please replace it with the corrected AddEntityFrameworkServerSideSessionsServices()
+
+### StateProviderPollingDelay and StateProviderPollingInterval have been split into separate options for WebAssembly and Server. 
+
+If you used BffBlazorOptions.StateProviderPollingInterval or BffBlazorOptions.StateProviderPollingDelay to configure different polling settings, you should now consider if this same setting applies to either Server, WASM or both. Set the appropriate properties accordingly.
+

bff/src/Bff.Blazor.Client/BffBlazorOptions.cs

@@ -27,15 +27,28 @@ public class BffBlazorOptions
     public string? StateProviderBaseAddress { get; set; } = null;
 
     /// <summary>
-    /// The delay, in milliseconds, before the AuthenticationStateProvider will
+    /// The delay, in milliseconds, before the BffClientAuthenticationStateProvider will
     /// start polling the /bff/user endpoint. Defaults to 1000 ms.
     /// </summary>
-    public int StateProviderPollingDelay { get; set; } = 1000;
+    public int WebAssemblyStateProviderPollingDelay { get; set; } = 1000;
 
     /// <summary>
     /// The delay, in milliseconds, between polling requests by the
-    /// AuthenticationStateProvider to the /bff/user endpoint. Defaults to 5000
+    /// BffClientAuthenticationStateProvider to the /bff/user endpoint. Defaults to 5000
     /// ms.
     /// </summary>
-    public int StateProviderPollingInterval { get; set; } = 5000;
+    public int WebAssemblyStateProviderPollingInterval { get; set; } = 5000;
+
+    /// <summary>
+    /// The delay, in milliseconds, before the BffServerAuthenticationStateProvider will
+    /// start polling the /bff/user endpoint. Defaults to 1000 ms.
+    /// </summary>
+    public int ServerStateProviderPollingDelay { get; set; } = 1000;
+
+    /// <summary>
+    /// The delay, in milliseconds, between polling requests by the
+    /// BffServerAuthenticationStateProvider to the /bff/user endpoint. Defaults to 5000
+    /// ms.
+    /// </summary>
+    public int ServerStateProviderPollingInterval { get; set; } = 5000;
 }

bff/src/Bff.Blazor.Client/BffClientAuthenticationStateProvider.cs

@@ -69,8 +69,8 @@ async void TimerCallback(object? _)
 
             timer = _timeProvider.CreateTimer(TimerCallback, 
             null, 
-            TimeSpan.FromMilliseconds(_options.StateProviderPollingDelay), 
-            TimeSpan.FromMilliseconds(_options.StateProviderPollingInterval));
+            TimeSpan.FromMilliseconds(_options.WebAssemblyStateProviderPollingDelay), 
+            TimeSpan.FromMilliseconds(_options.WebAssemblyStateProviderPollingInterval));
         }
         return state;
     }

bff/src/Bff.Blazor.Client/Internals/GetUserService.cs

@@ -45,7 +45,7 @@ public void InitializeCache()
     public async ValueTask<ClaimsPrincipal> GetUserAsync(bool useCache = true)
     {
         var now = _timeProvider.GetUtcNow();
-        if (useCache && now < _userLastCheck.AddMilliseconds(_options.StateProviderPollingDelay))
+        if (useCache && now < _userLastCheck.AddMilliseconds(_options.WebAssemblyStateProviderPollingDelay))
         {
             _logger.LogDebug("Taking user from cache");
             return _cachedUser;

bff/src/Bff.Blazor/BffServerAuthenticationStateProvider.cs

@@ -54,8 +54,7 @@ public BffServerAuthenticationStateProvider(
         _bffOptions = bffOptions.Value;
         _logger = loggerFactory.CreateLogger<BffServerAuthenticationStateProvider>();
 
-        // TODO - Consider separate options for server and client
-        RevalidationInterval = TimeSpan.FromMilliseconds(blazorOptions.Value.StateProviderPollingInterval);
+        RevalidationInterval = TimeSpan.FromMilliseconds(blazorOptions.Value.ServerStateProviderPollingInterval);
 
         AuthenticationStateChanged += OnAuthenticationStateChanged;
         _subscription = _state.RegisterOnPersisting(OnPersistingAsync, RenderMode.InteractiveWebAssembly);

bff/test/Bff.Blazor.Client.UnitTests/BffClientAuthenticationStateProviderTests.cs

@@ -61,8 +61,8 @@ public async Task after_configured_delay_UserService_is_called_again_and_state_n
             time,
             TestMocks.MockOptions(new BffBlazorOptions
             {
-                StateProviderPollingDelay = 2000,
-                StateProviderPollingInterval = 10000
+                WebAssemblyStateProviderPollingDelay = 2000,
+                WebAssemblyStateProviderPollingInterval = 10000
 
             }),
             Substitute.For<ILogger<BffClientAuthenticationStateProvider>>());
@@ -122,8 +122,8 @@ public async Task timer_stops_when_user_logs_out()
             time,
             TestMocks.MockOptions(new BffBlazorOptions
             {
-                StateProviderPollingDelay = 2000,
-                StateProviderPollingInterval = 10000
+                ServerStateProviderPollingDelay = 2000,
+                ServerStateProviderPollingInterval = 10000
 
             }),
             Substitute.For<ILogger<BffClientAuthenticationStateProvider>>());